Fix issue with --select and flake8 extensions; issue #216

Author: florentx

CHANGES.txt

@@ -2,6 +2,13 @@ Changelog
 =========
 
 
+1.x (unreleased)
+----------------
+
+* Fix ignoring too many checks when ``--select`` is used with codes
+  declared in a flake8 extension. (Issue #216)
+
+
 1.4.6 (2013-07-02)
 ------------------
 

pep8.py

@@ -45,7 +45,7 @@
 700 statements
 900 syntax error
 """
-__version__ = '1.4.6'
+__version__ = '1.4.7a0'
 
 import os
 import sys
@@ -1678,6 +1678,9 @@ def ignore_code(self, code):
         return False.  Else, if 'options.ignore' contains a prefix of
         the error code, return True.
         """
+        if len(code) < 4 and any(s.startswith(code)
+                                 for s in self.options.select):
+            return False
         return (code.startswith(self.options.ignore) and
                 not code.startswith(self.options.select))
 

testsuite/test_api.py

@@ -219,6 +219,13 @@ def parse_argv(argstring):
         self.assertFalse(pep8style.ignore_code('W191'))
         self.assertTrue(pep8style.ignore_code('E241'))
 
+        pep8style = pep8.StyleGuide(select=('F401',), paths=[E11])
+        self.assertEqual(pep8style.options.select, ('F401',))
+        self.assertEqual(pep8style.options.ignore, ('',))
+        self.assertFalse(pep8style.ignore_code('F'))
+        self.assertFalse(pep8style.ignore_code('F401'))
+        self.assertTrue(pep8style.ignore_code('F402'))
+
     def test_styleguide_excluded(self):
         pep8style = pep8.StyleGuide(paths=[E11])