Merge pull request #313 from hongqn/e721-noqa

allow use # noqa to disable E721 warning

Author: IanLee1521

docs/intro.rst

@@ -361,7 +361,7 @@ This is the current list of error and warning codes:
 +----------+----------------------------------------------------------------------+
 | E714     | test for object identity should be 'is not'                          |
 +----------+----------------------------------------------------------------------+
-| E721     | do not compare types, use 'isinstance()'                             |
+| E721 (^) | do not compare types, use 'isinstance()'                             |
 +----------+----------------------------------------------------------------------+
 | E731     | do not assign a lambda expression, use a def                         |
 +----------+----------------------------------------------------------------------+

pep8.py

@@ -1053,7 +1053,7 @@ def comparison_negative(logical_line):
             yield pos, "E714 test for object identity should be 'is not'"
 
 
-def comparison_type(logical_line):
+def comparison_type(logical_line, noqa):
     r"""Object type comparisons should always use isinstance().
 
     Do not compare types directly.
@@ -1069,7 +1069,7 @@ def comparison_type(logical_line):
     Okay: if type(a1) is type(b1):
     """
     match = COMPARE_TYPE_REGEX.search(logical_line)
-    if match:
+    if match and not noqa:
         inst = match.group(1)
         if inst and isidentifier(inst) and inst not in SINGLETONS:
             return  # Allow comparison for types which are not obvious