Skip to content

Commit f01edd6

Browse files
committed
Fix false positive E121/E126 with multi-line string; issue #265
1 parent d0df292 commit f01edd6

4 files changed

Lines changed: 20 additions & 4 deletions

File tree

CHANGES.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Changelog
55
1.5.x (unreleased)
66
------------------
77

8-
8+
* Fix false positive E121/E126 with multi-line strings. (Issue #265)
99

1010

1111
1.5.1 (2014-03-27)

pep8.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -556,6 +556,8 @@ def continued_indentation(logical_line, tokens, indent_level, hang_closing,
556556
indent_chances[start[1]] = text
557557

558558
last_token_multiline = (start[0] != end[0])
559+
if last_token_multiline:
560+
rel_indent[end[0] - first_row] = rel_indent[row]
559561

560562
if indent_next and expand_indent(line) == indent_level + 4:
561563
if visual_indent:

testsuite/E12not.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -632,3 +632,15 @@ def other_example():
632632
else 0,
633633
}
634634
#
635+
from textwrap import dedent
636+
637+
638+
print dedent(
639+
'''
640+
mkdir -p ./{build}/
641+
mv ./build/ ./{build}/%(revision)s/
642+
'''.format(
643+
build='build',
644+
# more stuff
645+
)
646+
)

testsuite/test_shell.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,11 @@ def test_check_simple(self):
8282
self.assertEqual(x, str(num))
8383
self.assertEqual(y, str(col))
8484
self.assertTrue(msg.startswith(' E11'))
85-
# Config file read from the pep8's tox.ini
86-
(config_filename,) = self._config_filenames
87-
self.assertTrue(config_filename.endswith('tox.ini'))
85+
# Config file read from the pep8's setup.cfg or tox.ini
86+
config_filenames = self._config_filenames
87+
self.assertEqual(len(config_filenames), 2)
88+
self.assertTrue(config_filenames[0].endswith('setup.cfg'))
89+
self.assertTrue(config_filenames[1].endswith('tox.ini'))
8890

8991
def test_check_stdin(self):
9092
pep8.PROJECT_CONFIG = ()

0 commit comments

Comments
 (0)