minor fixes

Author: shubhammalhotra28

examples/android/RunAnywhereAI/app/src/main/java/com/runanywhere/runanywhereai/presentation/lora/LoraAdapterPickerSheet.kt

@@ -223,7 +223,7 @@ private fun CatalogAdapterRow(
     onApply: (Float) -> Unit,
     onRemove: () -> Unit,
 ) {
-    var scale by remember(entry.id) { mutableFloatStateOf(entry.defaultScale) }
+    var scale by remember(entry.id, entry.defaultScale) { mutableFloatStateOf(entry.defaultScale) }
 
     Column(
         modifier = Modifier

examples/android/RunAnywhereAI/app/src/main/java/com/runanywhere/runanywhereai/presentation/lora/LoraViewModel.kt

@@ -31,6 +31,7 @@ data class LoraUiState(
     val registeredAdapters: List<LoraAdapterCatalogEntry> = emptyList(),
     val loadedAdapters: List<LoRAAdapterInfo> = emptyList(),
     val compatibleAdapters: List<LoraAdapterCatalogEntry> = emptyList(),
+    val downloadedAdapterPaths: Map<String, String> = emptyMap(),
     val downloadingAdapterId: String? = null,
     val downloadProgress: Float = 0f,
     val error: String? = null,
@@ -58,13 +59,15 @@ class LoraViewModel(application: Application) : AndroidViewModel(application) {
     fun refresh() {
         viewModelScope.launch {
             try {
-                val (registered, loaded) = withContext(Dispatchers.IO) {
-                    RunAnywhere.allRegisteredLoraAdapters() to RunAnywhere.getLoadedLoraAdapters()
+                val (registered, loaded, downloaded) = withContext(Dispatchers.IO) {
+                    val reg = RunAnywhere.allRegisteredLoraAdapters()
+                    Triple(reg, RunAnywhere.getLoadedLoraAdapters(), scanDownloadedAdapters(reg))
                 }
                 _uiState.update {
                     it.copy(
                         registeredAdapters = registered,
                         loadedAdapters = loaded,
+                        downloadedAdapterPaths = downloaded,
                         error = null,
                     )
                 }
@@ -79,13 +82,15 @@ class LoraViewModel(application: Application) : AndroidViewModel(application) {
     fun refreshForModel(modelId: String) {
         viewModelScope.launch {
             try {
-                val (compatible, loaded) = withContext(Dispatchers.IO) {
-                    RunAnywhere.loraAdaptersForModel(modelId) to RunAnywhere.getLoadedLoraAdapters()
+                val (compatible, loaded, downloaded) = withContext(Dispatchers.IO) {
+                    val compat = RunAnywhere.loraAdaptersForModel(modelId)
+                    Triple(compat, RunAnywhere.getLoadedLoraAdapters(), scanDownloadedAdapters(compat))
                 }
                 _uiState.update {
                     it.copy(
                         compatibleAdapters = compatible,
                         loadedAdapters = loaded,
+                        downloadedAdapterPaths = it.downloadedAdapterPaths + downloaded,
                         error = null,
                     )
                 }
@@ -151,15 +156,14 @@ class LoraViewModel(application: Application) : AndroidViewModel(application) {
         }
     }
 
-    /** Get the local file path for a catalog entry, or null if not downloaded. */
+    /** Get the local file path for a catalog entry, or null if not downloaded (reads from cached state). */
     fun localPath(entry: LoraAdapterCatalogEntry): String? {
-        val file = File(loraDir, entry.filename)
-        return if (file.exists()) file.absolutePath else null
+        return _uiState.value.downloadedAdapterPaths[entry.id]
     }
 
-    /** Check if a catalog entry is already downloaded. */
+    /** Check if a catalog entry is already downloaded (reads from cached state). */
     fun isDownloaded(entry: LoraAdapterCatalogEntry): Boolean {
-        return File(loraDir, entry.filename).exists()
+        return entry.id in _uiState.value.downloadedAdapterPaths
     }
 
     /** Check if a specific adapter is currently loaded. */
@@ -168,6 +172,14 @@ class LoraViewModel(application: Application) : AndroidViewModel(application) {
         return _uiState.value.loadedAdapters.any { it.path == path }
     }
 
+    /** Scan disk for downloaded adapter files and return id->path map. Must be called on IO dispatcher. */
+    private fun scanDownloadedAdapters(adapters: List<LoraAdapterCatalogEntry>): Map<String, String> {
+        return adapters.mapNotNull { entry ->
+            val file = File(loraDir, entry.filename)
+            if (file.exists()) entry.id to file.absolutePath else null
+        }.toMap()
+    }
+
     /** Download a LoRA adapter GGUF file. */
     fun downloadAdapter(entry: LoraAdapterCatalogEntry) {
         if (_uiState.value.downloadingAdapterId != null) return
@@ -221,6 +233,7 @@ class LoraViewModel(application: Application) : AndroidViewModel(application) {
                     it.copy(
                         downloadingAdapterId = null,
                         downloadProgress = 0f,
+                        downloadedAdapterPaths = it.downloadedAdapterPaths + (entry.id to destFile.absolutePath),
                     )
                 }
             } catch (e: Exception) {
@@ -269,7 +282,12 @@ class LoraViewModel(application: Application) : AndroidViewModel(application) {
                     }
                 }
                 val loaded = withContext(Dispatchers.IO) { RunAnywhere.getLoadedLoraAdapters() }
-                _uiState.update { it.copy(loadedAdapters = loaded) }
+                _uiState.update {
+                    it.copy(
+                        loadedAdapters = loaded,
+                        downloadedAdapterPaths = it.downloadedAdapterPaths - entry.id,
+                    )
+                }
             } catch (e: Exception) {
                 Timber.e(e, "Failed to delete adapter: ${entry.filename}")
                 _uiState.update { it.copy(error = "Delete failed: ${e.message}") }

sdk/runanywhere-commons/include/rac/core/rac_core.h

@@ -12,6 +12,7 @@
 #include "rac/core/rac_error.h"
 #include "rac/core/rac_types.h"
 #include "rac/infrastructure/model_management/rac_model_types.h"
+#include "rac/infrastructure/model_management/rac_lora_registry.h"
 #include "rac/infrastructure/network/rac_environment.h"
 
 #ifdef __cplusplus

sdk/runanywhere-commons/src/infrastructure/model_management/lora_registry.cpp

@@ -30,14 +30,23 @@ static rac_lora_entry_t* deep_copy_lora_entry(const rac_lora_entry_t* src) {
     copy->description = rac_strdup(src->description);
     copy->download_url = rac_strdup(src->download_url);
     copy->filename = rac_strdup(src->filename);
+
+    // id is required — if it failed to copy, the entry is unusable
+    if (src->id && !copy->id) {
+        free_lora_entry(copy);
+        return nullptr;
+    }
+
     if (src->compatible_model_ids && src->compatible_model_count > 0) {
         copy->compatible_model_ids = static_cast<char**>(malloc(sizeof(char*) * src->compatible_model_count));
-        if (copy->compatible_model_ids) {
-            for (size_t i = 0; i < src->compatible_model_count; ++i) {
-                copy->compatible_model_ids[i] = rac_strdup(src->compatible_model_ids[i]);
-            }
-            copy->compatible_model_count = src->compatible_model_count;
+        if (!copy->compatible_model_ids) {
+            free_lora_entry(copy);
+            return nullptr;
+        }
+        for (size_t i = 0; i < src->compatible_model_count; ++i) {
+            copy->compatible_model_ids[i] = rac_strdup(src->compatible_model_ids[i]);
         }
+        copy->compatible_model_count = src->compatible_model_count;
     }
     copy->file_size = src->file_size;
     copy->default_scale = src->default_scale;