fix(windows): address PR #470 review comments

- Remove unsafe `RAC_ORT_PATH` macro from rac_platform_compat.h — it
  returned `const wchar_t*` into a destroyed temporary `std::wstring`,
  UB at every call site. Replaced with a doc comment pinning the safe
  named-local pattern. Macro was never invoked; no code changes needed.
  (greptile #3081984814, coderabbit #3082012163)
- Guard `ENABLE_LIBGCC` with `if(MSVC)` so Linux+GCC keeps the default
  OFF behaviour; only MSVC forces it ON. Add rationale comment.
  (greptile #3081984920)
- Drop stale "Windows" from the backtrace-not-supported fallback
  comment in rac_structured_error.cpp — Windows has its own
  `CaptureStackBackTrace` branch now. (greptile #3081985002)
- Fix malformed MSVC generator expression in RAG CMakeLists.txt: use
  semicolon-separated flag list instead of space-separated so CMake
  parses all three `/wd` warning suppressions correctly.
  (coderabbit #3082012173)

macOS verification: `cmake --build` 100% clean, 51/51 tests pass.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: sanchitmonga22

sdk/runanywhere-commons/CMakeLists.txt

@@ -247,7 +247,16 @@ set(ENABLE_LIBXML2 OFF CACHE BOOL "" FORCE)
 set(ENABLE_EXPAT OFF CACHE BOOL "" FORCE)
 set(ENABLE_PCREPOSIX OFF CACHE BOOL "" FORCE)
 set(ENABLE_PCRE2POSIX OFF CACHE BOOL "" FORCE)
-set(ENABLE_LIBGCC ON CACHE BOOL "" FORCE)
+# libarchive's ENABLE_LIBGCC gates a `find_library(GCC_LIBRARY gcc)` / `-lgcc`
+# link. Needed on MSVC for the bundled runtime; a no-op on Apple/Clang (no
+# libgcc); on Linux+GCC keep it OFF so we don't add an explicit -lgcc to the
+# link line (it's pulled in implicitly and adding it can cause duplicate-symbol
+# warnings in static configurations).
+if(MSVC)
+    set(ENABLE_LIBGCC ON CACHE BOOL "" FORCE)
+else()
+    set(ENABLE_LIBGCC OFF CACHE BOOL "" FORCE)
+endif()
 set(ENABLE_CNG OFF CACHE BOOL "" FORCE)
 set(ENABLE_TAR OFF CACHE BOOL "" FORCE)      # Don't build bsdtar binary
 set(ENABLE_CPIO OFF CACHE BOOL "" FORCE)     # Don't build bsdcpio binary

sdk/runanywhere-commons/include/rac/core/rac_platform_compat.h

@@ -188,19 +188,13 @@ inline std::wstring rac_to_wstring(const char* s) {
     if (!s || !*s) return {};
     return rac_to_wstring(std::string(s));
 }
-/**
- * On Windows, ONNX Runtime expects wchar_t* paths.
- * NOTE: The macro returns a pointer into a temporary std::wstring. Callers MUST
- * store the result in a named local before calling .c_str(), otherwise the
- * pointer dangles at the end of the full-expression:
- *     std::wstring wp = rac_to_wstring(p);
- *     Ort::Session s(env, wp.c_str(), options);
- */
-#define RAC_ORT_PATH(p) rac_to_wstring(p).c_str()
-#else
-/** On non-Windows, ONNX Runtime expects char* paths */
-#define RAC_ORT_PATH(p) (p)
 #endif
+// ONNX Runtime path handling:
+//   - On Windows, use `std::wstring wp = rac_to_wstring(p); session(env, wp.c_str(), opts);`
+//   - On non-Windows, pass the `const char*` path directly.
+// No macro is provided on purpose: a macro returning `rac_to_wstring(p).c_str()`
+// would dangle at the end of the full-expression (the temporary wstring is
+// destroyed before Ort::Session reads from the pointer).
 
 #endif /* __cplusplus */
 

sdk/runanywhere-commons/src/backends/onnx/wakeword_onnx.cpp

@@ -567,7 +567,7 @@ RAC_ONNX_API rac_result_t rac_wakeword_onnx_init_shared_models(
     try {
         // Load melspectrogram model (required for proper pipeline).
         // Store the wstring in a named local so the wchar_t* outlives the ctor call
-        // (RAC_ORT_PATH returns a pointer into a temporary on Windows).
+        // (passing `rac_to_wstring(p).c_str()` directly would dangle).
         if (melspec_model_path) {
 #ifdef _WIN32
             std::wstring melspec_wpath = rac_to_wstring(melspec_model_path);

sdk/runanywhere-commons/src/core/rac_structured_error.cpp

@@ -246,7 +246,7 @@ int32_t rac_error_capture_stack_trace(rac_error_t* error) {
     error->stack_frame_count = captured;
     return captured;
 #else
-    // Platform doesn't support backtrace (Android, Windows, etc.)
+    // Platform doesn't support backtrace (Android NDK, etc.)
     error->stack_frame_count = 0;
     return 0;
 #endif

sdk/runanywhere-commons/src/features/rag/CMakeLists.txt

@@ -103,7 +103,7 @@ set_target_properties(rac_backend_rag PROPERTIES
 target_compile_options(rac_backend_rag PRIVATE
     $<$<CXX_COMPILER_ID:GNU,Clang,AppleClang>:-Wno-unused-parameter>
     $<$<CXX_COMPILER_ID:GNU,Clang,AppleClang>:-Wno-missing-field-initializers>
-    $<$<CXX_COMPILER_ID:MSVC>:/wd4244 /wd4267 /wd4996>
+    $<$<CXX_COMPILER_ID:MSVC>:/wd4244;/wd4267;/wd4996>
 )
 
 target_compile_definitions(rac_backend_rag PRIVATE