issue #52: use LinkedHashMap for deterministic order of query params

Author: Luis Miranda

core/src/main/java/com/onelogin/saml2/Auth.java

@@ -8,6 +8,7 @@
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.HashMap;
+import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
 
@@ -440,7 +441,7 @@ public void processSLO(Boolean keepLocalSession, String requestId) throws Except
 				logoutResponseBuilder.build(inResponseTo);
 				String samlLogoutResponse = logoutResponseBuilder.getEncodedLogoutResponse();
 
-				Map<String, String> parameters = new HashMap<String, String>();
+				Map<String, String> parameters = new LinkedHashMap<String, String>();
 
 				parameters.put("SAMLResponse", samlLogoutResponse);
 

core/src/test/java/com/onelogin/saml2/test/AuthTest.java

@@ -46,32 +46,32 @@
 
 /*
  * Known issues while testing
- * 
+ *
  * ECLEmma coverage plugin incompatible with PowerMock
  * http://stackoverflow.com/questions/23363212/powermock-eclemma-coverage-issue
  *
  * import org.junit.runner.RunWith;
- * import org.powermock.modules.junit4.PowerMockRunner; 
+ * import org.powermock.modules.junit4.PowerMockRunner;
  * @RunWith(PowerMockRunner.class)
- * 
+ *
  */
 @PrepareForTest({Auth.class})
 public class AuthTest {
 
 	/*
-	 * When using @PrepareForTest and PowerMockito the breakpoints when debugging 
+	 * When using @PrepareForTest and PowerMockito the breakpoints when debugging
 	 * does not work. Define Rules!
 	 * (http://stackoverflow.com/questions/35140575/powermockito-junit-and-eclemma-debugging-dosent-work)
-	 * 
+	 *
 	 * https://github.com/jayway/powermock/wiki/PowerMockRule
-	 * 
+	 *
 	 * import org.junit.Rule;
 	 * import org.powermock.modules.junit4.rule.PowerMockRule;
 	 * @Rule
 	 * public PowerMockRule rule = new PowerMockRule();
-	 * 
+	 *
 	 */
-	
+
 	//import org.powermock.modules.junit4.rule.PowerMockRule;
 	//@Rule
 	//public PowerMockRule rule = new PowerMockRule();
@@ -527,7 +527,7 @@ public void testProcessSLORequestSignRes() throws Exception {
 		assertFalse(auth.isAuthenticated());
 		assertTrue(auth.getErrors().isEmpty());
 		auth.processSLO();
-		verify(response).sendRedirect(matches("http:\\/\\/idp.example.com\\/simplesaml\\/saml2\\/idp\\/SingleLogoutService.php\\?SAMLResponse=(.)*&SigAlg=http%3A%2F%2Fwww.w3.org%2F2001%2F04%2Fxmldsig-more%23rsa-sha512&RelayState=http%3A%2F%2Flocalhost%3A8080%2Fexpected.jsp&Signature=(.)*"));
+		verify(response).sendRedirect(matches("http:\\/\\/idp.example.com\\/simplesaml\\/saml2\\/idp\\/SingleLogoutService.php\\?SAMLResponse=(.)*&RelayState=http%3A%2F%2Flocalhost%3A8080%2Fexpected.jsp&SigAlg=http%3A%2F%2Fwww.w3.org%2F2001%2F04%2Fxmldsig-more%23rsa-sha512&Signature=(.)*"));
 		verify(session, times(1)).invalidate();
 		assertTrue(auth.getErrors().isEmpty());
 	}