Skip to content

Commit aa89b3d

Browse files
pitbulkpitbulk
committed
Revert change of Signatures. Update commons-codec to 1.15. Update other libraries
1 parent 2ec5e12 commit aa89b3d

File tree

6 files changed

+20
-21
lines changed

6 files changed

+20
-21
lines changed

‎core/pom.xml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
<dependency>
6666
<groupId>commons-codec</groupId>
6767
<artifactId>commons-codec</artifactId>
68-
<version>1.14</version>
68+
<version>1.15</version>
6969
</dependency>
7070
</dependencies>
7171

@@ -74,7 +74,7 @@
7474
<plugin>
7575
<groupId>org.jacoco</groupId>
7676
<artifactId>jacoco-maven-plugin</artifactId>
77-
<version>0.8.2</version>
77+
<version>0.8.6</version>
7878
<configuration>
7979
<propertyName>jacoco.agent.argLine</propertyName>
8080
</configuration>
@@ -90,7 +90,7 @@
9090
<plugin>
9191
<groupId>org.apache.maven.plugins</groupId>
9292
<artifactId>maven-jar-plugin</artifactId>
93-
<version>2.4</version>
93+
<version>3.2.0</version>
9494
<executions>
9595
<execution>
9696
<goals>
@@ -102,15 +102,15 @@
102102
<plugin>
103103
<groupId>org.apache.maven.plugins</groupId>
104104
<artifactId>maven-surefire-plugin</artifactId>
105-
<version>2.12</version>
105+
<version>2.22.2</version>
106106
<configuration>
107107
<argLine>${jacoco.agent.argLine}</argLine>
108108
</configuration>
109109
</plugin>
110110
<plugin>
111111
<groupId>org.apache.maven.plugins</groupId>
112112
<artifactId>maven-enforcer-plugin</artifactId>
113-
<version>1.1.1</version>
113+
<version>1.4.1</version>
114114
<executions>
115115
<execution>
116116
<id>enforce</id>

‎core/src/test/java/com/onelogin/saml2/test/logout/LogoutRequestTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -735,7 +735,7 @@ public void testIsInValidSign() throws Exception {
735735
assertTrue(logoutRequest.isValid());
736736

737737
settings.setStrict(false);
738-
String signature2 = "x3Yq1dQ0S/6iirAPpkEYrDvY5mTqzQ3b1eE+sEmnmYbzDs5YHksRrc7uloHt7xqBcCGlk+ZI2USjKshf//OVRkSr8gZ8qYtth1v69hVpEvUdzhSANyJCOCENN2DhX8kc76Wg+VyR1mzbvbrap0G6lrj9TSuM4wyh68gzJDeTQbs=";
738+
String signature2 = "vfWbbc47PkP3ejx4bjKsRX7lo9Ml1WRoE5J5owF/0mnyKHfSY6XbhO1wwjBV5vWdrUVX+xp6slHyAf4YoAsXFS0qhan6txDiZY4Oec6yE+l10iZbzvie06I4GPak4QrQ4gAyXOSzwCrRmJu4gnpeUxZ6IqKtdrKfAYRAcVf3333=";
739739
httpRequest = httpRequest.removeParameter("Signature")
740740
.addParameter("Signature", signature2);
741741

‎core/src/test/java/com/onelogin/saml2/test/logout/LogoutResponseTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ public void testIsInValidSign() throws URISyntaxException, IOException, XMLEntit
523523
assertTrue(logoutResponse.isValid());
524524

525525
settings.setStrict(false);
526-
String signature2 = "x3Yq1dQ0S/6iirAPpkEYrDvY5mTqzQ3b1eE+sEmnmYbzDs5YHksRrc7uloHt7xqBcCGlk+ZI2USjKshf//OVRkSr8gZ8qYtth1v69hVpEvUdzhSANyJCOCENN2DhX8kc76Wg+VyR1mzbvbrap0G6lrj9TSuM4wyh68gzJDeTQbs=";
526+
String signature2 = "vfWbbc47PkP3ejx4bjKsRX7lo9Ml1WRoE5J5owF/0mnyKHfSY6XbhO1wwjBV5vWdrUVX+xp6slHyAf4YoAsXFS0qhan6txDiZY4Oec6yE+l10iZbzvie06I4GPak4QrQ4gAyXOSzwCrRmJu4gnpeUxZ6IqKtdrKfAYRAcVf3333=";
527527
httpRequest = httpRequest.removeParameter("Signature")
528528
.addParameter("Signature", signature2);
529529
logoutResponse = new LogoutResponse(settings, httpRequest);

‎core/src/test/java/com/onelogin/saml2/test/settings/SettingBuilderTest.java‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ public class SettingBuilderTest {
5454
* Case: config file not found
5555
*
5656
* @throws IOException
57-
* @throws SettingsException
5857
* @throws Error
5958
*
6059
* @see com.onelogin.saml2.settings.SettingsBuilder#fromFile

‎pom.xml‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<properties>
1414
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
1515
<slf4jVersion>1.7.30</slf4jVersion>
16-
<junitVersion>4.12</junitVersion>
16+
<junitVersion>4.13</junitVersion>
1717
<logbackVersion>1.2.3</logbackVersion>
1818
<apacheCommonsLangVersion>3.11</apacheCommonsLangVersion>
1919
</properties>
@@ -42,13 +42,13 @@
4242
<dependency>
4343
<groupId>org.hamcrest</groupId>
4444
<artifactId>hamcrest-core</artifactId>
45-
<version>1.3</version>
45+
<version>2.2</version>
4646
<scope>test</scope>
4747
</dependency>
4848
<dependency>
4949
<groupId>org.hamcrest</groupId>
5050
<artifactId>hamcrest-library</artifactId>
51-
<version>1.3</version>
51+
<version>2.2</version>
5252
<scope>test</scope>
5353
</dependency>
5454
<!-- for log -->
@@ -96,7 +96,7 @@
9696
<plugin>
9797
<groupId>org.owasp</groupId>
9898
<artifactId>dependency-check-maven</artifactId>
99-
<version>5.2.1</version>
99+
<version>6.0.2</version>
100100
<configuration>
101101
<failBuildOnCVSS>7</failBuildOnCVSS>
102102
<suppressionFiles>
@@ -116,7 +116,7 @@
116116
<plugins>
117117
<plugin>
118118
<artifactId>maven-compiler-plugin</artifactId>
119-
<version>3.5.1</version>
119+
<version>3.8.1</version>
120120
<configuration>
121121
<source>1.7</source>
122122
<target>1.7</target>
@@ -125,7 +125,7 @@
125125
<plugin>
126126
<groupId>org.apache.maven.plugins</groupId>
127127
<artifactId>maven-release-plugin</artifactId>
128-
<version>2.5</version>
128+
<version>2.5.3</version>
129129
<configuration>
130130
<autoVersionSubmodules>true</autoVersionSubmodules>
131131
<useReleaseProfile>false</useReleaseProfile>
@@ -183,7 +183,7 @@
183183
<plugin>
184184
<groupId>org.apache.maven.plugins</groupId>
185185
<artifactId>maven-source-plugin</artifactId>
186-
<version>2.2.1</version>
186+
<version>3.2.1</version>
187187
<executions>
188188
<execution>
189189
<id>attach-sources</id>
@@ -196,7 +196,7 @@
196196
<plugin>
197197
<groupId>org.apache.maven.plugins</groupId>
198198
<artifactId>maven-javadoc-plugin</artifactId>
199-
<version>2.9.1</version>
199+
<version>3.2.0</version>
200200
<configuration>
201201
<additionalparam>-Xdoclint:none</additionalparam>
202202
</configuration>
@@ -212,7 +212,7 @@
212212
<plugin>
213213
<groupId>org.apache.maven.plugins</groupId>
214214
<artifactId>maven-gpg-plugin</artifactId>
215-
<version>1.5</version>
215+
<version>1.6</version>
216216
<executions>
217217
<execution>
218218
<id>sign-artifacts</id>

‎toolkit/pom.xml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
<dependency>
6262
<groupId>javax.servlet</groupId>
6363
<artifactId>javax.servlet-api</artifactId>
64-
<version>3.1.0</version>
64+
<version>4.0.1</version>
6565
<scope>provided</scope>
6666
</dependency>
6767

@@ -86,7 +86,7 @@
8686
<dependency>
8787
<groupId>commons-codec</groupId>
8888
<artifactId>commons-codec</artifactId>
89-
<version>1.14</version>
89+
<version>1.15</version>
9090
</dependency>
9191
</dependencies>
9292

@@ -95,7 +95,7 @@
9595
<plugin>
9696
<groupId>org.jacoco</groupId>
9797
<artifactId>jacoco-maven-plugin</artifactId>
98-
<version>0.8.2</version>
98+
<version>0.8.6</version>
9999
<configuration>
100100
<propertyName>jacoco.agent.argLine</propertyName>
101101
</configuration>
@@ -111,7 +111,7 @@
111111
<plugin>
112112
<groupId>org.apache.maven.plugins</groupId>
113113
<artifactId>maven-surefire-plugin</artifactId>
114-
<version>2.12</version>
114+
<version>2.22.2</version>
115115
<configuration>
116116
<argLine>${jacoco.agent.argLine}</argLine>
117117
</configuration>

0 commit comments

Comments
 (0)