Adds # support in HttpRequest query string parsing

HttpRequest.getEncodedParameter() will now return the
corrent value for the last parameter before the #.

Example: foo=bar#ignore now returns 'bar' and not 'bar#ignore'
for the 'foo' parameter.

Author: merit\rembjo0

core/src/main/java/com/onelogin/saml2/http/HttpRequest.java

@@ -152,7 +152,7 @@ public Map<String, List<String>> getParameters() {
      * @return the first value for the parameter, or null
      */
     public String getEncodedParameter(String name) {
-        Matcher matcher = Pattern.compile(Pattern.quote(name) + "=([^&]+)").matcher(queryString);
+        Matcher matcher = Pattern.compile(Pattern.quote(name) + "=([^&#]+)").matcher(queryString);
         if (matcher.find()) {
             return matcher.group(1);
         } else {

core/src/test/java/com/onelogin/saml2/http/HttpRequestTest.java

@@ -142,6 +142,16 @@ public void testGetEncodedParameter_handlesMultipleValuesOnQueryString() throws
         assertThat(request.getEncodedParameter("k3"), equalTo("v3"));
     }
 
+    @Test
+    public void testGetEncodedParameter_stopsAtUrlFragment() throws Exception {
+        final String url = "url";
+        final String queryString = "first=&foo=bar#ignore";
+
+        final HttpRequest request = new HttpRequest(url, queryString);
+
+        assertThat(request.getEncodedParameter("foo"), equalTo("bar"));
+    }
+
     @Test
     public void testGetEncodedParameter_withDefault_usesDefaultWhenParameterMissing() throws Exception {
         final String url = "url";