Skip to content

Commit f4059bf

Browse files
committed
Remove the useless Exception throws declaration in LogoutRequest.isValid
Two reasons for removal: - avoid the need of a useless try/catch on consuming code - align API to LogoutResponse.isValid() and SamlResponse.isValid() The code is backward compatible, because an existing surrounding try/catch(Exception) won't cause a compilation error after the change.
1 parent 523786b commit f4059bf

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

core/src/main/java/com/onelogin/saml2/logout/LogoutRequest.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -358,14 +358,12 @@ private static StringBuilder getLogoutRequestTemplate() {
358358
return template;
359359
}
360360

361-
/**
362-
* Determines if the SAML LogoutRequest is valid or not
363-
*
364-
* @return true if the SAML LogoutRequest is valid
365-
*
366-
* @throws Exception
367-
*/
368-
public Boolean isValid() throws Exception {
361+
/**
362+
* Determines if the SAML LogoutRequest is valid or not
363+
*
364+
* @return true if the SAML LogoutRequest is valid
365+
*/
366+
public Boolean isValid() {
369367
validationException = null;
370368

371369
try {

0 commit comments

Comments
 (0)