Add proper return value annotations for \OneLogin_Saml2_Response::getId and \OneLogin_Saml2_Response::getAssertionId

LukasReschke · LukasReschke · commit cc0e5c1a09f1 · 2017-10-03T16:27:05.000+02:00
Signed-off-by: Lukas Reschke &lt;lukas@statuscode.ch&gt;
diff --git a/lib/Saml2/Response.php b/lib/Saml2/Response.php
@@ -409,7 +409,7 @@ public function isValid($requestId = null)
     }
 
     /**
-     * @return the ID of the Response
+     * @return string|null the ID of the Response
      */
     public function getId()
     {
@@ -421,7 +421,7 @@ public function getId()
     }
 
     /**
-     * @return the ID of the assertion in the Response
+     * @return string|null the ID of the assertion in the Response
      */
     public function getAssertionId()
     {

Original file line number	Diff line number	Diff line change
`@@ -409,7 +409,7 @@ public function isValid($requestId = null)`
`409`	`409`	`}`
`410`	`410`
`411`	`411`	`/**`
`412`		`- * @return the ID of the Response`
	`412`	`+ * @return string\|null the ID of the Response`
`413`	`413`	`*/`
`414`	`414`	`public function getId()`
`415`	`415`	`{`
`@@ -421,7 +421,7 @@ public function getId()`
`421`	`421`	`}`
`422`	`422`
`423`	`423`	`/**`
`424`		`- * @return the ID of the assertion in the Response`
	`424`	`+ * @return string\|null the ID of the assertion in the Response`
`425`	`425`	`*/`
`426`	`426`	`public function getAssertionId()`
`427`	`427`	`{`