Skip to content

Commit 6207906

Browse files
committed
Removed TODO updating docstrings
1 parent 70988bd commit 6207906

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

src/onelogin/saml2/settings.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ def get_sp_key(self):
489489
Returns the x509 private key of the SP.
490490
491491
:returns: SP private key
492-
:rtype: string
492+
:rtype: string or None
493493
"""
494494
key = self.__sp.get('privateKey')
495495
key_file_name = self.__paths['cert'] + 'sp.key'
@@ -498,14 +498,14 @@ def get_sp_key(self):
498498
with open(key_file_name) as f:
499499
key = f.read()
500500

501-
return key or None # TODO: Should change rtype docstrings or update tests
501+
return key or None
502502

503503
def get_sp_cert(self):
504504
"""
505505
Returns the x509 public cert of the SP.
506506
507507
:returns: SP public cert
508-
:rtype: string
508+
:rtype: string or None
509509
"""
510510
cert = self.__sp.get('x509cert')
511511
cert_file_name = self.__paths['cert'] + 'sp.crt'
@@ -514,7 +514,7 @@ def get_sp_cert(self):
514514
with open(cert_file_name) as f:
515515
cert = f.read()
516516

517-
return cert or None # TODO: Should change rtype docstrings or update tests
517+
return cert or None
518518

519519
def get_idp_cert(self):
520520
"""

0 commit comments

Comments
 (0)