Fixes Windows specific Unix date formatting bug. Use time() instead of datetime.now().strftime('%s')

Author: pitbulk

src/onelogin/saml2/metadata.py

@@ -9,7 +9,7 @@
 
 """
 
-from time import gmtime, strftime
+from time import gmtime, strftime, time
 from datetime import datetime
 from defusedxml.minidom import parseString
 
@@ -54,7 +54,7 @@ def builder(sp, authnsign=False, wsign=False, valid_until=None, cache_duration=N
         :type organization: dict
         """
         if valid_until is None:
-            valid_until = int(datetime.now().strftime("%s")) + OneLogin_Saml2_Metadata.TIME_VALID
+            valid_until = int(time()) + OneLogin_Saml2_Metadata.TIME_VALID
         if not isinstance(valid_until, basestring):
             if isinstance(valid_until, datetime):
                 valid_until_time = valid_until.timetuple()

src/onelogin/saml2/settings.py

@@ -9,9 +9,9 @@
 
 """
 
-from datetime import datetime
 import json
 import re
+from time import time
 from os.path import dirname, exists, join, sep, abspath
 from xml.dom.minidom import Document
 
@@ -735,7 +735,7 @@ def validate_metadata(self, xml):
                         cache_duration = element.getAttribute('cacheDuration')
 
                     expire_time = OneLogin_Saml2_Utils.get_expire_time(cache_duration, valid_until)
-                    if expire_time is not None and int(datetime.now().strftime('%s')) > int(expire_time):
+                    if expire_time is not None and int(time()) > int(expire_time):
                         errors.append('expired_xml')
 
         # TODO: Validate Sign