Skip to content

Commit 1cb34cd

Browse files
author
Tessa Bloomer
committed
Fixed comment
1 parent f11d48f commit 1cb34cd

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

tests/src/OneLogin/saml2_tests/response_test.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1036,7 +1036,7 @@ def testIsInValidDestination(self):
10361036
self.assertFalse(response_2.is_valid(self.get_request_data()))
10371037
self.assertIn('The response was received at', response_2.get_error())
10381038

1039-
def testIsInValidCapitalizationOfDestinationElements(self):
1039+
def testIsInValidDestinationCapitalizationOfElements(self):
10401040
"""
10411041
Tests the is_valid method of the OneLogin_Saml2_Response class
10421042
Case Invalid Response due to differences in capitalization of path
@@ -1056,19 +1056,21 @@ def testIsInValidCapitalizationOfDestinationElements(self):
10561056
self.assertFalse(response_2.is_valid(self.get_request_data_both_capitalized()))
10571057
self.assertIn('The response was received at', response_2.get_error())
10581058

1059-
def testIsValidCapitalizationOfDestinationHost(self):
1059+
def testIsValidDestinationCapitalizationOfHost(self):
10601060
"""
10611061
Tests the is_valid method of the OneLogin_Saml2_Response class
10621062
Case Valid Response, even if host is differently capitalized (per RFC)
10631063
"""
10641064
settings = OneLogin_Saml2_Settings(self.loadSettingsJSON())
10651065
message = self.file_contents(join(self.data_path, 'responses', 'unsigned_response.xml.base64'))
10661066

1067-
#Test path capitalized
1067+
#Test domain capitalized
10681068
settings.set_strict(True)
10691069
response = OneLogin_Saml2_Response(settings, message)
10701070
self.assertFalse(response.is_valid(self.get_request_data_domain_capitalized()))
10711071
self.assertNotIn('The response was received at', response.get_error())
1072+
#Assert we got past the destination check, which appears later
1073+
self.assertIn('A valid SubjectConfirmation was not found', response.get_error())
10721074

10731075
def testIsInValidAudience(self):
10741076
"""

0 commit comments

Comments
 (0)