Skip to content

Commit 5eaad0a

Browse files
authored
Fix misleading comment with fingerprint hash weaker than a certificate verification
The reasoning of a fingerprint hash weaker than providing a certificate like a CA is wrong. A X509 signature of a certificate always uses a Hash like SHA1, SHA256, etc, which is then signed. E.g. openssl1.1 x509 -text -in sp-test.pem Signature Algorithm: ecdsa-with-SHA256 So these are as vulnerable to collision attacks as fingeprints. Depending on the implementation of the fingerprint, there are other for not using them. E.g. some implementation ignore other problem with a certificate like validity or missing EKUs.
1 parent ef2efa7 commit 5eaad0a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -323,8 +323,8 @@ This is the ``settings.json`` file:
323323
/*
324324
* Instead of using the whole X.509cert you can use a fingerprint in order to
325325
* validate a SAMLResponse (but you still need the X.509cert to validate LogoutRequest and LogoutResponse using the HTTP-Redirect binding).
326-
* But take in mind that the fingerprint, is a hash, so at the end is open to a collision attack that can end on a signature validation bypass,
327-
* that why we don't recommend it use for production environments.
326+
* But take in mind that the algortithm for the fingerprint should be as strong as the algorithm in a normal certificate signature
327+
* (e.g. SHA256 or strong)
328328
*
329329
* (openssl x509 -noout -fingerprint -in "idp.crt" to generate it,
330330
* or add for example the -sha256 , -sha384 or -sha512 parameter)

0 commit comments

Comments
 (0)