rename returnUrl to responseUrl

Author: BeritJanssen

README.md

@@ -306,7 +306,7 @@ This is the ``settings.json`` file:
             "url": "https://app.onelogin.com/trust/saml2/http-redirect/slo/<onelogin_connector_id>",
             // URL Location where the <Response> from the SP will returned (after IdP-initiated logout)
             // OPTIONAL: only specify if different from url parameter 
-            "returnUrl": "https://app.onelogin.com/trust/saml2/http-redirect/slo_return/<onelogin_connector_id>"
+            "responseUrl": "https://app.onelogin.com/trust/saml2/http-redirect/slo_return/<onelogin_connector_id>"
             // SAML protocol binding to be used when returning the <Response>
             // message. OneLogin Toolkit supports the HTTP-Redirect binding
             // only for this endpoint.

src/onelogin/saml2/auth.py

@@ -190,7 +190,7 @@ def process_slo(self, keep_local_session=False, request_id=None, delete_session_
                 if security['logoutResponseSigned']:
                     self.add_response_signature(parameters, security['signatureAlgorithm'])
 
-                return self.redirect_to(self.get_slo_return_url(), parameters)
+                return self.redirect_to(self.get_slo_response_url(), parameters)
         else:
             self.__errors.append('invalid_binding')
             raise OneLogin_Saml2_Error(
@@ -468,15 +468,15 @@ def get_slo_url(self):
         if 'url' in idp_data['singleLogoutService']:
             return idp_data['singleLogoutService']['url']
 
-    def get_slo_return_url(self):
+    def get_slo_response_url(self):
         """
         Gets the SLO return URL for IdP-initiated logout.
 
         :returns: an URL, the SLO return endpoint of the IdP
         :rtype: string
         """
         slo_data = self.__settings.get_idp_data()['singleLogoutService']
-        return slo_data.get('returnUrl', self.get_slo_url())
+        return slo_data.get('responseUrl', self.get_slo_url())
 
     def add_request_signature(self, request_data, sign_algorithm=OneLogin_Saml2_Constants.RSA_SHA1):
         """

src/onelogin/saml2/logout_response.py

@@ -162,7 +162,7 @@ def build(self, in_response_to):
 
         uid = OneLogin_Saml2_Utils.generate_unique_id()
         issue_instant = OneLogin_Saml2_Utils.parse_time_to_SAML(OneLogin_Saml2_Utils.now())
-        destination = idp_data['singleLogoutService'].get('returnUrl', idp_data['singleLogoutService']['url'])
+        destination = idp_data['singleLogoutService'].get('responseUrl', idp_data['singleLogoutService']['url'])
 
         logout_response = OneLogin_Saml2_Templates.LOGOUT_RESPONSE % \
             {

tests/src/OneLogin/saml2_tests/auth_test.py

@@ -87,20 +87,20 @@ def testGetSLOurl(self):
         slo_url = settings_info['idp']['singleLogoutService']['url']
         self.assertEqual(auth.get_slo_url(), slo_url)
 
-    def testGetSLOReturnUrl(self):
+    def testGetSLOresponseUrl(self):
         """
-        Tests the get_slo_return_url method of the OneLogin_Saml2_Auth class
+        Tests the get_slo_response_url method of the OneLogin_Saml2_Auth class
         """
         settings_info = self.loadSettingsJSON()
-        settings_info['idp']['singleLogoutService']['returnUrl'] = "http://idp.example.com/SingleLogoutReturn.php"
+        settings_info['idp']['singleLogoutService']['responseUrl'] = "http://idp.example.com/SingleLogoutReturn.php"
         auth = OneLogin_Saml2_Auth(self.get_request(), old_settings=settings_info)
-        slo_url = settings_info['idp']['singleLogoutService']['returnUrl']
-        self.assertEqual(auth.get_slo_return_url(), slo_url)
-        # test that the function falls back to the url setting if returnUrl is not set
-        settings_info['idp']['singleLogoutService'].pop('returnUrl')
+        slo_url = settings_info['idp']['singleLogoutService']['responseUrl']
+        self.assertEqual(auth.get_slo_response_url(), slo_url)
+        # test that the function falls back to the url setting if responseUrl is not set
+        settings_info['idp']['singleLogoutService'].pop('responseUrl')
         auth = OneLogin_Saml2_Auth(self.get_request(), old_settings=settings_info)
         slo_url = settings_info['idp']['singleLogoutService']['url']
-        self.assertEqual(auth.get_slo_return_url(), slo_url)
+        self.assertEqual(auth.get_slo_response_url(), slo_url)
 
 
     def testGetSessionIndex(self):