Merge pull request #283 from guneskaan/get-last-response-in-response-to-id

Implement Auth.get_last_response_in_response_to()

Author: pitbulk

README.md

@@ -1005,6 +1005,7 @@ Main class of OneLogin Python Toolkit
 * ***set_strict*** Set the strict mode active/disable.
 * ***get_last_request_xml*** Returns the most recently-constructed/processed XML SAML request (``AuthNRequest``, ``LogoutRequest``)
 * ***get_last_response_xml*** Returns the most recently-constructed/processed XML SAML response (``SAMLResponse``, ``LogoutResponse``). If the SAMLResponse had an encrypted assertion, decrypts it.
+* ***get_last_response_in_response_to*** The `InResponseTo` ID of the most recently processed SAML Response.
 * ***get_last_message_id*** The ID of the last Response SAML message processed.
 * ***get_last_assertion_id*** The ID of the last assertion processed.
 * ***get_last_assertion_not_on_or_after*** The ``NotOnOrAfter`` value of the valid ``SubjectConfirmationData`` node (if any) of the last assertion processed (is only calculated with strict = true)

src/onelogin/saml2/auth.py

@@ -75,6 +75,7 @@ def __init__(self, request_data, old_settings=None, custom_base_path=None):
         self._last_authn_contexts = []
         self._last_request = None
         self._last_response = None
+        self._last_response_in_response_to = None
         self._last_assertion_not_on_or_after = None
 
     def get_settings(self):
@@ -109,6 +110,7 @@ def store_valid_response(self, response):
         self._last_assertion_issue_instant = response.get_assertion_issue_instant()
         self._last_authn_contexts = response.get_authn_contexts()
         self._authenticated = True
+        self._last_response_in_response_to = response.get_in_response_to()
         self._last_assertion_not_on_or_after = response.get_assertion_not_on_or_after()
 
     def process_response(self, request_id=None):
@@ -389,6 +391,13 @@ def get_last_authn_contexts(self):
         """
         return self._last_authn_contexts
 
+    def get_last_response_in_response_to(self):
+        """
+        :returns: InResponseTo attribute of the last Response SAML processed or None if it is not present.
+        :rtype: string
+        """
+        return self._last_response_in_response_to
+
     def login(self, return_to=None, force_authn=False, is_passive=False, set_nameid_policy=True, name_id_value_req=None):
         """
         Initiates the SSO process.

tests/src/OneLogin/saml2_tests/auth_test.py

@@ -1415,7 +1415,7 @@ def testGetLastLogoutResponse(self):
 
     def testGetInfoFromLastResponseReceived(self):
         """
-        Tests the get_last_message_id, get_last_assertion_id, get_last_assertion_not_on_or_after and get_last_assertion_issue_instant
+        Tests the get_last_response_in_response_to, get_last_message_id, get_last_assertion_id, get_last_assertion_not_on_or_after and get_last_assertion_issue_instant
         of the OneLogin_Saml2_Auth class
         """
         settings = self.loadSettingsJSON()
@@ -1428,6 +1428,7 @@ def testGetInfoFromLastResponseReceived(self):
         auth = OneLogin_Saml2_Auth(request_data, old_settings=settings)
 
         auth.process_response()
+        self.assertEqual(auth.get_last_response_in_response_to(), 'ONELOGIN_5fe9d6e499b2f0913206aab3f7191729049bb807')
         self.assertEqual(auth.get_last_message_id(), 'pfx42be40bf-39c3-77f0-c6ae-8bf2e23a1a2e')
         self.assertEqual(auth.get_last_assertion_id(), 'pfx57dfda60-b211-4cda-0f63-6d5deb69e5bb')
         self.assertIsNone(auth.get_last_assertion_not_on_or_after())
@@ -1440,6 +1441,7 @@ def testGetInfoFromLastResponseReceived(self):
         auth = OneLogin_Saml2_Auth(request_data, old_settings=settings)
         auth.process_response()
         self.assertNotEqual(len(auth.get_errors()), 0)
+        self.assertIsNone(auth.get_last_response_in_response_to())
         self.assertIsNone(auth.get_last_message_id())
         self.assertIsNone(auth.get_last_assertion_id())
         self.assertIsNone(auth.get_last_assertion_not_on_or_after())
@@ -1451,6 +1453,7 @@ def testGetInfoFromLastResponseReceived(self):
         auth = OneLogin_Saml2_Auth(request_data, old_settings=settings)
         auth.process_response()
         self.assertEqual(len(auth.get_errors()), 0)
+        self.assertEqual(auth.get_last_response_in_response_to(), 'ONELOGIN_5fe9d6e499b2f0913206aab3f7191729049bb807')
         self.assertEqual(auth.get_last_message_id(), 'pfx42be40bf-39c3-77f0-c6ae-8bf2e23a1a2e')
         self.assertEqual(auth.get_last_assertion_id(), 'pfx57dfda60-b211-4cda-0f63-6d5deb69e5bb')
         self.assertEqual(auth.get_last_assertion_not_on_or_after(), 2671081021)