Skip to content

Commit ff278e2

Browse files
authored
Update authn_request.py
fix conditions
1 parent ba1fb05 commit ff278e2

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

src/onelogin/saml2/authn_request.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -100,18 +100,20 @@ def __init__(self, settings, force_authn=False, is_passive=False, set_nameid_pol
100100
if not security["requestedAuthnContext"]:
101101
authn_comparison = security["requestedAuthnContextComparison"]
102102

103-
if security["requestedAuthnContext"]:
103+
if isinstance(security["requestedAuthnContext"], list):
104+
requested_authn_context_str = ' <samlp:RequestedAuthnContext Comparison="%s">' % authn_comparison
105+
for authn_context in security["requestedAuthnContext"]:
106+
requested_authn_context_str += "<saml:AuthnContextClassRef>%s</saml:AuthnContextClassRef>" % authn_context
107+
requested_authn_context_str += " </samlp:RequestedAuthnContext>"
108+
109+
else:
104110
requested_authn_context_str = (
105111
""" <samlp:RequestedAuthnContext Comparison="%s">
106112
<saml:AuthnContextClassRef>urn:oasis:names:tc:SAML:2.0:ac:classes:PasswordProtectedTransport</saml:AuthnContextClassRef>
107113
</samlp:RequestedAuthnContext>"""
108114
% authn_comparison
109115
)
110-
else:
111-
requested_authn_context_str = ' <samlp:RequestedAuthnContext Comparison="%s">' % authn_comparison
112-
for authn_context in security["requestedAuthnContext"]:
113-
requested_authn_context_str += "<saml:AuthnContextClassRef>%s</saml:AuthnContextClassRef>" % authn_context
114-
requested_authn_context_str += " </samlp:RequestedAuthnContext>"
116+
115117

116118
attr_consuming_service_str = ""
117119
if "attributeConsumingService" in sp_data and sp_data["attributeConsumingService"]:

0 commit comments

Comments
 (0)