Skip to content

Commit 0aed0dc

Browse files
committed
Merge pull request #246 from stian-fredrikstad/master
On LogoutResponse, the issuer has to be before the status.
2 parents 4fa2ed9 + 5571dd5 commit 0aed0dc

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

lib/onelogin/ruby-saml/slo_logoutresponse.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,11 @@ def create_logout_response_xml_doc(settings, request_id = nil, logout_message =
104104
root.attributes['InResponseTo'] = request_id unless request_id.nil?
105105
root.attributes['Destination'] = settings.idp_slo_target_url unless settings.idp_slo_target_url.nil?
106106

107+
if settings.issuer != nil
108+
issuer = root.add_element "saml:Issuer"
109+
issuer.text = settings.issuer
110+
end
111+
107112
# add success message
108113
status = root.add_element 'samlp:Status'
109114

@@ -116,11 +121,6 @@ def create_logout_response_xml_doc(settings, request_id = nil, logout_message =
116121
status_message = status.add_element 'samlp:StatusMessage'
117122
status_message.text = logout_message
118123

119-
if settings.issuer != nil
120-
issuer = root.add_element "saml:Issuer"
121-
issuer.text = settings.issuer
122-
end
123-
124124
# embed signature
125125
if settings.security[:logout_responses_signed] && settings.private_key && settings.certificate && settings.security[:embed_sign]
126126
private_key = settings.get_sp_key

0 commit comments

Comments
 (0)