Merge pull request #739 from johnnyshields/better-fix-for-jruby

[READY] v2.x Fix JRuby, 2nd attempt

Author: pitbulk

test/test_helper.rb

@@ -500,13 +500,12 @@ def encrypt_xml(assertion_xml, private_key)
 # Remove after https://github.com/jruby/jruby/issues/6613 is fixed
 if Minitest::Test.jruby?
   module JRubyZlibTestExtension
-    @@jruby_zlib_failures = 0
-
-    def run
+    def capture_exceptions
       super
-    rescue Zlib::BufError => e
-      raise e unless (@@jruby_zlib_failures += 1) < 10
-      skip "Skipping Zlib::BufError in JRuby, see https://github.com/jruby/jruby/issues/6613"
+
+      if failures&.reject! { |e| e.error&.is_a?(Zlib::BufError) } # nil if nothing rejected
+        failures << Minitest::Skip.new('Skipping Zlib::BufError in JRuby. See: https://github.com/jruby/jruby/issues/6613')
+      end
     end
   end