Skip to content

Commit 407dc46

Browse files
committed
Update upgrading message
1 parent 91a7d27 commit 407dc46

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

UPGRADING.md

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -62,20 +62,15 @@ settings.security[:signature_method] = RubySaml::XML::Crypto::RSA_SHA1
6262

6363
### Behavior change of double_quote_xml_attribute_values setting
6464

65-
`settings.double_quote_xml_attribute_values` now always behaves as if it is set to `true`,
66-
i.e. RubySaml now always uses double quotes for attribute values when generating XML.
65+
RubySaml now always uses double quotes for attribute values when generating XML.
66+
The `settings.double_quote_xml_attribute_values` parameter now always behaves as `true`,
67+
and will be removed in RubySaml 2.1.0.
6768

6869
The reasons for this change are:
6970
- RubySaml will use Nokogiri instead of REXML to generate XML. Nokogiri does not support
7071
generating XML with single quotes.
71-
- Double quotes in XML tends to be the standard; there are no known SAML clients in the wild
72-
which cannot support double-quoted XML.
73-
74-
If you require to use single quotes in your XML output, you may try the following Regexp:
75-
76-
```ruby
77-
78-
```
72+
- Double-quoted XML attributes are more commonly used than single quotes. There are no known
73+
SAML clients which cannot support double-quoted XML.
7974

8075
### Removal of embed_sign setting
8176

0 commit comments

Comments
 (0)