Port malformed doc commit

Author: johnnyshields

lib/ruby_saml/logoutresponse.rb

@@ -151,7 +151,8 @@ def validate_success_status
     # @raise [ValidationError] if soft == false and validation fails
     #
     def validate_structure
-      unless valid_saml?(document, soft)
+      check_malformed_doc = check_malformed_doc?(settings)
+      unless valid_saml?(document, soft, check_malformed_doc: check_malformed_doc)
         return append_error("Invalid SAML Logout Response. Not match the saml-schema-protocol-2.0.xsd")
       end
 

lib/ruby_saml/response.rb

@@ -450,11 +450,12 @@ def validate_success_status
     def validate_structure
       structure_error_msg = "Invalid SAML Response. Not match the saml-schema-protocol-2.0.xsd"
 
-      unless valid_saml?(document, soft, check_malformed_doc: check_malformed_doc_enabled?)
+      check_malformed_doc = check_malformed_doc_enabled?
+      unless valid_saml?(document, soft, check_malformed_doc: check_malformed_doc)
         return append_error(structure_error_msg)
       end
 
-      if decrypted_document && !valid_saml?(decrypted_document, soft, check_malformed_doc: check_malformed_doc_enabled?)
+      if decrypted_document && !valid_saml?(decrypted_document, soft, check_malformed_doc: check_malformed_doc)
         return append_error(structure_error_msg)
       end
 
@@ -1106,9 +1107,7 @@ def parse_time(node, attribute)
     end
 
     def check_malformed_doc_enabled?
-      default_value = RubySaml::Settings::DEFAULTS[:check_malformed_doc]
-
-      settings.nil? ? default_value : settings.check_malformed_doc
+      check_malformed_doc?(settings)
     end
   end
 end

lib/ruby_saml/saml_message.rb

@@ -167,5 +167,11 @@ def inflate(deflated)
     def deflate(inflated)
       Zlib::Deflate.deflate(inflated, Zlib::BEST_COMPRESSION)[2..-5]
     end
+
+    def check_malformed_doc?(settings)
+      default_value = RubySaml::Settings::DEFAULTS[:check_malformed_doc]
+
+      settings.nil? ? default_value : settings.check_malformed_doc
+    end
   end
 end

lib/ruby_saml/slo_logoutrequest.rb

@@ -233,7 +233,8 @@ def validate_not_on_or_after
     # @raise [ValidationError] if soft == false and validation fails
     #
     def validate_structure
-      unless valid_saml?(document, soft)
+      check_malformed_doc = check_malformed_doc?(settings)
+      unless valid_saml?(document, soft, check_malformed_doc: check_malformed_doc)
         return append_error("Invalid SAML Logout Request. Not match the saml-schema-protocol-2.0.xsd")
       end