Skip to content

Commit 5520d79

Browse files
committed
Fix test. Fix dependencies in order to be able to run tests on ruby3.2.0
1 parent 9b10103 commit 5520d79

3 files changed

Lines changed: 10 additions & 2 deletions

File tree

.github/workflows/test.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,4 +32,5 @@ jobs:
3232
uses: coverallsapp/github-action@master
3333
with:
3434
github-token: ${{ secrets.GITHUB_TOKEN }}
35+
flag-name: run-${{ matrix.ruby-version }}
3536
parallel-finished: true

ruby-saml.gemspec

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,15 @@ Gem::Specification.new do |s|
4949
s.add_development_dependency('coveralls')
5050
s.add_development_dependency('minitest', '~> 5.5')
5151
s.add_development_dependency('mocha', '~> 0.14')
52-
s.add_development_dependency('rake', '~> 10')
53-
s.add_development_dependency('shoulda', '~> 2.11')
52+
53+
if RUBY_VERSION < '3.2'
54+
s.add_development_dependency('rake', '~> 10')
55+
else
56+
s.add_development_dependency('rake', '~> 12')
57+
end
58+
5459
s.add_development_dependency('simplecov', '<0.22.0')
60+
s.add_development_dependency('shoulda', '~> 2.11')
5561
s.add_development_dependency('systemu', '~> 2')
5662

5763
if RUBY_VERSION < '2.1'

test/response_test.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1355,6 +1355,7 @@ def generate_audience_error(expected, actual)
13551355

13561356
describe '#xpath_first_from_signed_assertion' do
13571357
it 'not allow arbitrary code execution' do
1358+
$evalled = nil
13581359
malicious_response_document = fixture('response_eval', false)
13591360
malicious_response = OneLogin::RubySaml::Response.new(malicious_response_document)
13601361
malicious_response.send(:xpath_first_from_signed_assertion)

0 commit comments

Comments
 (0)