Enable more cops

Author: johnnyshields

.rubocop.yml

@@ -1,33 +1,14 @@
 inherit_from: .rubocop_todo.yml
 
+require:
+  - rubocop-minitest
+  - rubocop-performance
+  - rubocop-rake
+
 AllCops:
   TargetRubyVersion: 2.6
-  NewCops: disable
+  NewCops: enable
   Include:
     - 'lib/**/*'
   Exclude:
     - '**/*.xsd'
-
-#Bundler:
-#  Enabled: false
-#
-#Gemspec:
-#  Enabled: false
-#
-#Layout:
-#  Enabled: false
-#
-#Lint:
-#  Enabled: false
-#
-#Metrics:
-#  Enabled: false
-#
-#Naming:
-#  Enabled: false
-#
-#Security:
-#  Enabled: true
-#
-#Style:
-#  Enabled: false

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-03-08 07:33:39 UTC using RuboCop version 1.45.1.
+# on 2023-03-08 07:46:47 UTC using RuboCop version 1.45.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -22,13 +22,12 @@ Layout/ClosingParenthesisIndentation:
     - 'lib/onelogin/ruby-saml/response.rb'
     - 'lib/xml_security.rb'
 
-# Offense count: 7
+# Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowForAlignment.
 Layout/CommentIndentation:
   Exclude:
     - 'lib/onelogin/ruby-saml/logoutresponse.rb'
-    - 'lib/xml_security.rb'
 
 # Offense count: 11
 # This cop supports safe autocorrection (--autocorrect).
@@ -135,18 +134,6 @@ Layout/FirstHashElementIndentation:
     - 'lib/onelogin/ruby-saml/authrequest.rb'
     - 'lib/onelogin/ruby-saml/metadata.rb'
 
-# Offense count: 40
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
-# SupportedHashRocketStyles: key, separator, table
-# SupportedColonStyles: key, separator, table
-# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
-Layout/HashAlignment:
-  Exclude:
-    - 'lib/onelogin/ruby-saml/logoutresponse.rb'
-    - 'lib/onelogin/ruby-saml/settings.rb'
-    - 'lib/onelogin/ruby-saml/slo_logoutrequest.rb'
-
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
@@ -280,6 +267,13 @@ Layout/TrailingWhitespace:
     - 'lib/onelogin/ruby-saml/attributes.rb'
     - 'lib/onelogin/ruby-saml/idp_metadata_parser.rb'
 
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+Lint/AmbiguousOperatorPrecedence:
+  Exclude:
+    - 'lib/onelogin/ruby-saml/idp_metadata_parser.rb'
+    - 'lib/onelogin/ruby-saml/utils.rb'
+
 # Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: AllowSafeAssignment.
@@ -303,6 +297,11 @@ Lint/MissingSuper:
     - 'lib/onelogin/ruby-saml/slo_logoutrequest.rb'
     - 'lib/onelogin/ruby-saml/slo_logoutresponse.rb'
 
+# Offense count: 2
+Lint/NoReturnInBeginEndBlocks:
+  Exclude:
+    - 'lib/onelogin/ruby-saml/idp_metadata_parser.rb'
+
 # Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: AllowedImplicitNamespaces.
@@ -331,7 +330,7 @@ Lint/UselessAssignment:
 # Offense count: 39
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
 Metrics/AbcSize:
-  Max: 96
+  Max: 101
 
 # Offense count: 1
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
@@ -418,6 +417,48 @@ Naming/VariableName:
   Exclude:
     - 'lib/onelogin/ruby-saml/utils.rb'
 
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Performance/Casecmp:
+  Exclude:
+    - 'lib/onelogin/ruby-saml/utils.rb'
+
+# Offense count: 1
+# Configuration parameters: MinSize.
+Performance/CollectionLiteralInLoop:
+  Exclude:
+    - 'lib/onelogin/ruby-saml/response.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Performance/RegexpMatch:
+  Exclude:
+    - 'lib/onelogin/ruby-saml/idp_metadata_parser.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Performance/StringIdentifierArgument:
+  Exclude:
+    - 'lib/onelogin/ruby-saml/saml_message.rb'
+
+# Offense count: 5
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Performance/StringInclude:
+  Exclude:
+    - 'lib/onelogin/ruby-saml/authrequest.rb'
+    - 'lib/onelogin/ruby-saml/logoutrequest.rb'
+    - 'lib/onelogin/ruby-saml/slo_logoutresponse.rb'
+    - 'lib/onelogin/ruby-saml/utils.rb'
+
+# Offense count: 8
+# This cop supports safe autocorrection (--autocorrect).
+Performance/StringReplacement:
+  Exclude:
+    - 'lib/onelogin/ruby-saml/metadata.rb'
+    - 'lib/onelogin/ruby-saml/saml_message.rb'
+    - 'lib/onelogin/ruby-saml/utils.rb'
+    - 'lib/xml_security.rb'
+
 # Offense count: 54
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
@@ -541,14 +582,13 @@ Style/GlobalStdStream:
   Exclude:
     - 'lib/onelogin/ruby-saml/logging.rb'
 
-# Offense count: 5
+# Offense count: 4
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: MinBodyLength, AllowConsecutiveConditionals.
 Style/GuardClause:
   Exclude:
     - 'lib/onelogin/ruby-saml/response.rb'
     - 'lib/onelogin/ruby-saml/utils.rb'
-    - 'lib/xml_security.rb'
 
 # Offense count: 69
 # This cop supports safe autocorrection (--autocorrect).
@@ -566,28 +606,30 @@ Style/IfUnlessModifier:
     - 'lib/onelogin/ruby-saml/utils.rb'
     - 'lib/xml_security.rb'
 
-# Offense count: 20
+# Offense count: 2
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: literals, strict
 Style/MutableConstant:
   Exclude:
     - 'lib/onelogin/ruby-saml/response.rb'
     - 'lib/onelogin/ruby-saml/saml_message.rb'
-    - 'lib/onelogin/ruby-saml/utils.rb'
-    - 'lib/onelogin/ruby-saml/version.rb'
-    - 'lib/xml_security.rb'
 
-# Offense count: 3
+# Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: both, prefix, postfix
 Style/NegatedIf:
   Exclude:
-    - 'lib/onelogin/ruby-saml/idp_metadata_parser.rb'
     - 'lib/onelogin/ruby-saml/response.rb'
     - 'lib/onelogin/ruby-saml/settings.rb'
 
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Style/NegatedIfElseCondition:
+  Exclude:
+    - 'lib/onelogin/ruby-saml/authrequest.rb'
+
 # Offense count: 6
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, MinBodyLength.
@@ -676,6 +718,13 @@ Style/PreferredHashMethods:
 Style/RaiseArgs:
   EnforcedStyle: compact
 
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Methods.
+Style/RedundantArgument:
+  Exclude:
+    - 'lib/xml_security.rb'
+
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 Style/RedundantBegin:

Gemfile

@@ -8,9 +8,9 @@ gem 'minitest', '~> 5.18', require: false
 gem 'mocha', '~> 2.0', require: false
 gem 'rake', '~> 13.0'
 gem 'rubocop', '~> 1.45.1'
+gem 'rubocop-minitest', '~> 0.22.2'
 gem 'rubocop-performance', '~> 1.16.0'
 gem 'rubocop-rake', '~> 0.6.0'
-gem 'rubocop-minitest', '~> 0.22.2'
 gem 'simplecov', '~> 0.22', require: false
 gem 'simplecov-lcov', '~> 0.8', require: false
 gem 'timecop', '~> 0.9', require: false