Use new behaviour only providing a flag

Author: davidlibrera

lib/onelogin/ruby-saml/settings.rb

@@ -9,10 +9,15 @@ module RubySaml
     # SAML2 Toolkit Settings
     #
     class Settings
-      def initialize(overrides = {})
-        security_attributes = overrides.delete(:security) || {}
-        config = DEFAULTS.merge(overrides)
-        config[:security] = DEFAULTS[:security].merge(security_attributes)
+      def initialize(overrides = {}, keep_security_attributes = false)
+        if keep_security_attributes
+          security_attributes = overrides.delete(:security) || {}
+          config = DEFAULTS.merge(overrides)
+          config[:security] = DEFAULTS[:security].merge(security_attributes)
+        else
+          config = DEFAULTS.merge(overrides)
+        end
+
         config.each do |k,v|
           acc = "#{k.to_s}=".to_sym
           if respond_to? acc

test/settings_test.rb

@@ -77,7 +77,7 @@ class SettingsTest < Minitest::Test
       assert_equal new_settings.security[:signature_method], XMLSecurity::Document::RSA_SHA1
     end
 
-    it "overrides only provided security attributes" do
+    it "overrides only provided security attributes passing a second parameter" do
       config = {
         :security => {
           :metadata_signed => true
@@ -86,11 +86,25 @@ class SettingsTest < Minitest::Test
 
       @default_attributes = OneLogin::RubySaml::Settings::DEFAULTS
 
-      @settings = OneLogin::RubySaml::Settings.new(config)
+      @settings = OneLogin::RubySaml::Settings.new(config, true)
       assert_equal @settings.security[:metadata_signed], true
       assert_equal @settings.security[:digest_method], @default_attributes[:security][:digest_method]
     end
 
+    it "doesn't override only provided security attributes without passing a second parameter" do
+      config = {
+        :security => {
+          :metadata_signed => true
+        }
+      }
+
+      @default_attributes = OneLogin::RubySaml::Settings::DEFAULTS
+
+      @settings = OneLogin::RubySaml::Settings.new(config)
+      assert_equal @settings.security[:metadata_signed], true
+      assert_equal @settings.security[:digest_method], nil
+    end
+
     describe "#single_logout_service_url" do
       it "when single_logout_service_url is nil but assertion_consumer_logout_service_url returns its value" do
         @settings.single_logout_service_url = nil