Improve tests

Author: johnnyshields

test/authrequest_test.rb

@@ -174,7 +174,18 @@ class AuthrequestTest < Minitest::Test
         request.create(settings)
 
         assert_match(/^_/, request.uuid)
-        assert_equal request.request_id, request.uuid
+        assert_equal request.uuid, request.request_id
+      end
+
+      it "does not change even after repeated #create calls" do
+        request = RubySaml::Authrequest.new
+        request.create(settings)
+
+        uuid = request.uuid
+        request.create(settings)
+
+        assert_equal uuid, request.uuid
+        assert_equal request.uuid, request.request_id
       end
 
       it "creates request with ID prefixed by Settings#sp_uuid_prefix" do
@@ -183,7 +194,7 @@ class AuthrequestTest < Minitest::Test
         request.create(settings)
 
         assert_match(/^test/, request.uuid)
-        assert_equal request.request_id, request.uuid
+        assert_equal request.uuid, request.request_id
       end
 
       it "can mutate the uuid" do
@@ -192,7 +203,7 @@ class AuthrequestTest < Minitest::Test
         assert_equal request_id, request.uuid
         request.uuid = "new_uuid"
         assert_equal "new_uuid", request.uuid
-        assert_equal request.request_id, request.uuid
+        assert_equal request.uuid, request.request_id
       end
     end
 

test/logoutrequest_test.rb

@@ -99,13 +99,26 @@ class RequestTest < Minitest::Test
         request = RubySaml::Logoutrequest.new
 
         assert_nil(request.uuid)
+        assert_equal request.request_id, request.uuid
       end
 
       it "creates request with ID prefixed with default '_'" do
         request = RubySaml::Logoutrequest.new
         request.create(settings)
 
         assert_match(/^_/, request.uuid)
+        assert_equal request.uuid, request.request_id
+      end
+
+      it "does not change even after repeated #create calls" do
+        request = RubySaml::Logoutrequest.new
+        request.create(settings)
+
+        uuid = request.uuid
+        request.create(settings)
+
+        assert_equal uuid, request.uuid
+        assert_equal request.uuid, request.request_id
       end
 
       it "creates request with ID prefixed by Settings#sp_uuid_prefix" do
@@ -114,6 +127,7 @@ class RequestTest < Minitest::Test
         request.create(settings)
 
         assert_match(/^test/, request.uuid)
+        assert_equal request.uuid, request.request_id
       end
 
       it "can mutate the uuid" do
@@ -122,7 +136,7 @@ class RequestTest < Minitest::Test
         assert_equal request_id, request.uuid
         request.uuid = "new_uuid"
         assert_equal "new_uuid", request.uuid
-        assert_equal request.request_id, request.uuid
+        assert_equal request.uuid, request.request_id
       end
     end
 

test/slo_logoutresponse_test.rb

@@ -95,7 +95,18 @@ class SloLogoutresponseTest < Minitest::Test
         response.create(settings)
 
         assert_match(/^_/, response.uuid)
-        assert_equal response.response_id, response.uuid
+        assert_equal response.uuid, response.response_id
+      end
+
+      it "does not change even after repeated #create calls" do
+        response = RubySaml::SloLogoutresponse.new
+        response.create(settings)
+
+        uuid = response.uuid
+        response.create(settings)
+
+        assert_equal uuid, response.uuid
+        assert_equal response.uuid, response.response_id
       end
 
       it "creates response with ID prefixed by Settings#sp_uuid_prefix" do
@@ -104,16 +115,16 @@ class SloLogoutresponseTest < Minitest::Test
         response.create(settings)
 
         assert_match(/^test/, response.uuid)
-        assert_equal response.response_id, response.uuid
+        assert_equal response.uuid, response.response_id
       end
 
-      it "be able to modify the response id" do
+      it "can mutate the uuid" do
         response = RubySaml::SloLogoutresponse.new
         response_id = response.response_id
         assert_equal response_id, response.uuid
         response.uuid = "new_uuid"
         assert_equal "new_uuid", response.uuid
-        assert_equal response.response_id, response.uuid
+        assert_equal response.uuid, response.response_id
       end
     end