Skip to content

Commit 211b91e

Browse files
committed
docs: revise ADR 0004 per reviewer feedback
Address all 4 [MAJOR] and 4 [MINOR] reviewer issues: MAJOR: - Move evidence files from gitignored docs/superpowers/evidence/ to docs/adrs/0004-evidence/ for external verifiability - Surface "no Playwright E2E test passed during PoC" as Important caveat callout at the top of the Evidence section, plus reflected in Track B table and Risk consequences - Tighten 25x framing: explicit rate-vs-ratio language, ~20x ratio on tested surface, defensible 3-5x estimate for full port with stated methodology - Add single-sample caveat to Selenium 4 section: one element measured; qualitative architectural claim (LWC host names brittle as Aura) generalizes, specific 14-statement cost is a single data point MINOR: - Quantify Phase M4 downstream PR burden honestly: 6-12 month tail across NPSP/EDA/OFM/V4S, capacity is binding constraint - Surface compatibility-shim vs runtime-translator cost asymmetry: shim is days/weeks, runtime translator is weeks; defer until usage data - Trim methodology prose to one paragraph in active voice with named artifacts and links - Fix frontmatter author syntax to "@jstvz" matching ADRs 0002, 0003 - Add Option 5 (reduce surface) and Option 6 (hybrid: new Playwright, freeze Selenium) with dismissal rationale NIT: - Spell out 14-statement math decomposition explicitly - Cite selenium pin location (pyproject.toml lines 50, 54) - Beef up References with source-file links (locators_66.py, SalesforcePlaywright.py, Salesforce.py, e2e_comparison.robot, pyproject.toml) - Clarify "452 shadow roots" framing: count of hosts, not unreachable elements Plus: TL;DR at top per reviewer's optional improvement.
1 parent b3249e3 commit 211b91e

4 files changed

Lines changed: 105 additions & 67 deletions

File tree

docs/superpowers/evidence/2026-04-27-robot-poc/selenium4_findings.md renamed to docs/adrs/0004-evidence/findings.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
- Isolated venv at `/tmp/selenium4-poc/` with `selenium==4.43.0` and headless Chrome.
1111
- Authenticated via Salesforce frontdoor URL (`/secur/frontdoor.jsp?sid=<access_token>`).
12-
- Two scripts: `selenium4_verify_shadow_dom.py` (overall capability) and `selenium4_measure_nesting.py` (depth measurement).
12+
- Two scripts: [`verify_shadow_dom.py`](verify_shadow_dom.py) (overall capability) and [`measure_nesting.py`](measure_nesting.py) (depth measurement).
1313

1414
## Measurements
1515

@@ -46,8 +46,8 @@ For the Account list view alone, with 452 shadow roots, anything that depends on
4646
# In a clean tmpdir
4747
uv venv .venv --python 3.13
4848
uv pip install --python ./.venv 'selenium>=4'
49-
./.venv/bin/python selenium4_verify_shadow_dom.py
50-
./.venv/bin/python selenium4_measure_nesting.py
49+
./.venv/bin/python verify_shadow_dom.py
50+
./.venv/bin/python measure_nesting.py
5151
```
5252

5353
Requires `sf` CLI authenticated against an org alias and the script edited to point at it.

docs/superpowers/evidence/2026-04-27-robot-poc/selenium4_measure_nesting.py renamed to docs/adrs/0004-evidence/measure_nesting.py

File renamed without changes.

docs/superpowers/evidence/2026-04-27-robot-poc/selenium4_verify_shadow_dom.py renamed to docs/adrs/0004-evidence/verify_shadow_dom.py

File renamed without changes.

0 commit comments

Comments
 (0)