Commit 211b91e
committed
docs: revise ADR 0004 per reviewer feedback
Address all 4 [MAJOR] and 4 [MINOR] reviewer issues:
MAJOR:
- Move evidence files from gitignored docs/superpowers/evidence/ to
docs/adrs/0004-evidence/ for external verifiability
- Surface "no Playwright E2E test passed during PoC" as Important caveat
callout at the top of the Evidence section, plus reflected in Track B
table and Risk consequences
- Tighten 25x framing: explicit rate-vs-ratio language, ~20x ratio on
tested surface, defensible 3-5x estimate for full port with stated
methodology
- Add single-sample caveat to Selenium 4 section: one element measured;
qualitative architectural claim (LWC host names brittle as Aura)
generalizes, specific 14-statement cost is a single data point
MINOR:
- Quantify Phase M4 downstream PR burden honestly: 6-12 month tail across
NPSP/EDA/OFM/V4S, capacity is binding constraint
- Surface compatibility-shim vs runtime-translator cost asymmetry:
shim is days/weeks, runtime translator is weeks; defer until usage data
- Trim methodology prose to one paragraph in active voice with named
artifacts and links
- Fix frontmatter author syntax to "@jstvz" matching ADRs 0002, 0003
- Add Option 5 (reduce surface) and Option 6 (hybrid: new Playwright,
freeze Selenium) with dismissal rationale
NIT:
- Spell out 14-statement math decomposition explicitly
- Cite selenium pin location (pyproject.toml lines 50, 54)
- Beef up References with source-file links (locators_66.py,
SalesforcePlaywright.py, Salesforce.py, e2e_comparison.robot,
pyproject.toml)
- Clarify "452 shadow roots" framing: count of hosts, not unreachable
elements
Plus: TL;DR at top per reviewer's optional improvement.1 parent b3249e3 commit 211b91e
4 files changed
Lines changed: 105 additions & 67 deletions
File tree
- docs/adrs
- 0004-evidence
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
50 | | - | |
| 49 | + | |
| 50 | + | |
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
0 commit comments