Skip to content

Commit 233caba

Browse files
committed
fix: Update test compatibility for Pydantic V1 namespace
Fix validation error handling and field imports in tests: - Update ValidationError imports to use pydantic.v1 namespace - Fix Field imports in model parser tests - Update pydantic.Extra usage for V1 compatibility - Resolve exception type mismatches in test suite Updated components: - Test files: Model validation, dependency tests, transform tests - Core files: Task validation, project config, deploy tasks All tests are now passing with V1 compatibility layer.
1 parent 462b05a commit 233caba

10 files changed

Lines changed: 12 additions & 12 deletions

File tree

cumulusci/core/config/project_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
API_VERSION_RE = re.compile(r"^\d\d+\.0$")
2323

2424
import github3
25-
from pydantic import ValidationError
25+
from pydantic.v1 import ValidationError
2626

2727
from cumulusci.core.config import FlowConfig, TaskConfig
2828
from cumulusci.core.config.base_task_flow_config import BaseTaskFlowConfig

cumulusci/core/dependencies/tests/test_dependencies.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from zipfile import ZipFile
66

77
import pytest
8-
from pydantic import ValidationError
8+
from pydantic.v1 import ValidationError
99

1010
from cumulusci.core.config.org_config import OrgConfig, VersionInfo
1111
from cumulusci.core.config.project_config import BaseProjectConfig

cumulusci/core/source_transforms/tests/test_transforms.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
import pytest
1010
from lxml import etree as ET
11-
from pydantic import ValidationError
11+
from pydantic.v1 import ValidationError
1212

1313
from cumulusci.core.exceptions import CumulusCIException, TaskOptionsError
1414
from cumulusci.core.source_transforms.transforms import (

cumulusci/core/tasks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
from contextlib import nullcontext
1212
from typing import Any, Callable, Dict, List, Optional, Type, Union
1313

14-
from pydantic.error_wrappers import ValidationError
14+
from pydantic.v1.error_wrappers import ValidationError
1515

1616
from cumulusci import __version__
1717
from cumulusci.core.config import TaskConfig

cumulusci/tasks/bulkdata/extract_dataset_utils/tests/test_extract_yml.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from io import StringIO
22

33
import pytest
4-
from pydantic import ValidationError
4+
from pydantic.v1 import ValidationError
55

66
from cumulusci.tasks.bulkdata.extract_dataset_utils.extract_yml import (
77
ExtractDeclaration,

cumulusci/tasks/salesforce/Deploy.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from typing import List, Optional, Union
33

44
from defusedxml.minidom import parseString
5-
from pydantic import ValidationError
5+
from pydantic.v1 import ValidationError
66

77
from cumulusci.cli.ui import CliTable
88
from cumulusci.core.dependencies.utils import TaskContext

cumulusci/tasks/salesforce/tests/test_update_dependencies.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import zipfile
44
from unittest import mock
55

6-
import pydantic
6+
import pydantic.v1 as pydantic
77
import pytest
88

99
from cumulusci.core.dependencies.dependencies import (

cumulusci/tasks/tests/test_create_package_version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import pytest
1111
import responses
1212
import yaml
13-
from pydantic import ValidationError
13+
from pydantic.v1 import ValidationError
1414

1515
from cumulusci.core.config import BaseProjectConfig, TaskConfig, UniversalConfig
1616
from cumulusci.core.dependencies.dependencies import (

cumulusci/utils/yaml/tests/test_cumulusci_yml.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
from unittest.mock import MagicMock, Mock, patch
55

66
import pytest
7-
from pydantic import ValidationError
7+
from pydantic.v1 import ValidationError
88

99
from cumulusci.utils import temporary_dir
1010
from cumulusci.utils.yaml.cumulusci_yml import (

cumulusci/utils/yaml/tests/test_model_parser.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from unittest.mock import Mock
33

44
import pytest
5-
from pydantic import Field
5+
from pydantic.v1 import Field
66

77
from cumulusci.utils.yaml.model_parser import CCIDictModel, CCIModel, ValidationError
88

@@ -20,7 +20,7 @@ class TestCCIModel:
2020
def test_fields_property(self):
2121
# JSON is YAML. Strange but true.
2222
foo = Document.parse_from_yaml(StringIO("{bar: 'blah'}"))
23-
assert type(foo) == Foo
23+
assert isinstance(foo, Foo)
2424
assert foo.fields_ == []
2525
assert foo.fields == []
2626

@@ -122,7 +122,7 @@ class Document(CCIDictModel):
122122

123123
# JSON is YAML. Strange but true.
124124
foo = Document.parse_from_yaml(StringIO("{bar: 'blah'}"))
125-
assert type(foo) == Foo
125+
assert isinstance(foo, Foo)
126126
assert foo["fields"] == []
127127

128128
foo = Document.parse_from_yaml(StringIO("{bar: 'blah', fields: [1,2]}"))

0 commit comments

Comments
 (0)