changed find_element by id in Salesforce.py and basepage objects

Author: arvindbhamidipati

cumulusci/robotframework/Salesforce.py

@@ -913,7 +913,7 @@ def _locate_element_by_label(self, browser, locator, tag, constraints):
             except NoSuchElementException:
                 component_id = label_element.get_attribute("for")
                 if component_id:
-                    component = browser.find_element_by_id(component_id)
+                    component = browser.find_element(By.ID, component_id)
                 # else find an input or textarea in a sibling or descendant?
             finally:
                 self.selenium.set_selenium_implicit_wait(orig_wait)

cumulusci/robotframework/pageobjects/BasePageObjects.py

@@ -276,7 +276,7 @@ def _get_form_element_for_label(self, label):
             try:
                 label_element = root.find_element(By.XPATH, f'//label[text()="{label}"]')
                 input_id = label_element.get_attribute("for")
-                element = root.find_element_by_id(input_id)
+                element = root.find_element(By.ID, input_id)
                 return element
 
             except NoSuchElementException: