Skip to content

Commit 3f8fa00

Browse files
committed
fix(robot): fix viewport type and update ADR with Playwright findings
Cast viewport width/height to int in SalesforcePlaywright.open_test_browser. Update ADR 0004 to note pre-existing wait_until_salesforce_is_ready bug that prevents Playwright E2E execution.
1 parent 4089b8c commit 3f8fa00

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

cumulusci/robotframework/SalesforcePlaywright.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,8 @@ def open_test_browser(
107107

108108
browser_id = self.browser.new_browser(browser=browser_enum, headless=headless)
109109
context_id = self.browser.new_context(
110-
viewport={"width": width, "height": height}, recordVideo=record_video
110+
viewport={"width": int(width), "height": int(height)},
111+
recordVideo=record_video,
111112
)
112113
self.browser.set_browser_timeout("15 seconds")
113114
page_details = self.browser.new_page(login_url)

docs/adrs/0004-robot-framework-selenium-vs-playwright.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,10 @@ The PoC produced concrete evidence for this recommendation:
7474

7575
**Track B — Playwright keyword port:**
7676

77-
- **~8 keywords** were ported using accessibility-first selectors (`role=`, `text=`).
77+
- **10 keywords** were ported using accessibility-first selectors (CSS, `text=`, SLDS classes).
7878
- **Zero version-specific locators** were required.
7979
- Playwright's **auto-wait** eliminated the need for `@selenium_retry` decorators entirely.
80+
- Pre-existing bug in `SalesforcePlaywright.wait_until_salesforce_is_ready` prevents end-to-end execution (URL regex mismatch). Keywords are structurally correct; test infrastructure needs a separate fix.
8081

8182
**Shadow DOM evidence:** The actions ribbon and List View Controls button are confirmed to render inside shadow DOM. This class of failure grows with each API version as Salesforce migrates more components from Aura to LWC.
8283

0 commit comments

Comments
 (0)