Raise validation errors for missing schema and permissions

Author: aditya-balachander

cumulusci/tasks/bulkdata/mapping_parser.py

@@ -444,9 +444,9 @@ def replace_if_necessary(dct, name, replacement):
             except KeyError:
                 message = f"Field {self.sf_object}.{f} does not exist or is not visible to the current user."
                 if validation_result:
-                    validation_result.add_warning(message)
+                    validation_result.add_error(message)
                 else:
-                    logger.warning(message)
+                    logger.error(message)
             else:
                 del field_dict[f]
                 field_dict[new_name] = entry
@@ -463,9 +463,9 @@ def replace_if_necessary(dct, name, replacement):
             if f not in describe:
                 message = f"Field {self.sf_object}.{f} does not exist or is not visible to the current user."
                 if validation_result:
-                    validation_result.add_warning(message)
+                    validation_result.add_error(message)
                 else:
-                    logger.warning(message)
+                    logger.error(message)
                 error_in_f = True
             elif not self._check_field_permission(
                 describe,
@@ -480,9 +480,9 @@ def replace_if_necessary(dct, name, replacement):
                     + f"{relevant_permissions} for this operation."
                 )
                 if validation_result:
-                    validation_result.add_warning(message)
+                    validation_result.add_error(message)
                 else:
-                    logger.warning(message)
+                    logger.error(message)
                 error_in_f = True
 
             if error_in_f:
@@ -514,9 +514,9 @@ def _validate_sobject(
         except KeyError:
             message = f"sObject {self.sf_object} does not exist or is not visible to the current user."
             if validation_result:
-                validation_result.add_warning(message)
+                validation_result.add_error(message)
             else:
-                logger.warning(message)
+                logger.error(message)
             return False
 
         # Validate our access to this sObject.
@@ -525,9 +525,9 @@ def _validate_sobject(
         ):
             message = f"sObject {self.sf_object} does not have the correct permissions for {data_operation_type}."
             if validation_result:
-                validation_result.add_warning(message)
+                validation_result.add_error(message)
             else:
-                logger.warning(message)
+                logger.error(message)
             return False
 
         return True

cumulusci/tasks/bulkdata/tests/test_mapping_parser.py

@@ -1868,8 +1868,9 @@ def test_validate_only_collects_missing_field_errors(self):
 
         assert result is not None
         assert isinstance(result, ValidationResult)
-        # Should have warnings about missing field
-        assert any("Nonsense__c" in warning for warning in result.warnings)
+        assert result.has_errors()
+        # Should have errors about missing field
+        assert any("Nonsense__c" in error for error in result.errors)
 
     @responses.activate
     def test_validate_only_collects_missing_required_field_errors(self):
@@ -1930,8 +1931,9 @@ def test_validate_only_early_return_on_sobject_error(self):
 
         assert result is not None
         assert isinstance(result, ValidationResult)
-        # Should have warning about missing object
-        assert any("InvalidObject__c" in warning for warning in result.warnings)
+        assert result.has_errors()
+        # Should have error about missing object
+        assert any("InvalidObject__c" in error for error in result.errors)
 
     @responses.activate
     def test_validate_only_collects_lookup_errors(self):
@@ -2068,7 +2070,7 @@ def test_check_required_without_validation_result_logs(self, caplog):
         assert "Name" in caplog.text
 
     def test_validate_sobject_with_validation_result(self):
-        """Test _validate_sobject adds warnings to ValidationResult"""
+        """Test _validate_sobject adds errors to ValidationResult"""
         from cumulusci.tasks.bulkdata.mapping_parser import ValidationResult
 
         ms = MappingStep(
@@ -2087,13 +2089,11 @@ def test_validate_sobject_with_validation_result(self):
         )
 
         assert not result
-        assert len(validation_result.warnings) > 0
-        assert any(
-            "InvalidObject__c" in warning for warning in validation_result.warnings
-        )
+        assert validation_result.has_errors()
+        assert any("InvalidObject__c" in error for error in validation_result.errors)
 
     def test_validate_field_dict_with_validation_result(self):
-        """Test _validate_field_dict adds warnings to ValidationResult"""
+        """Test _validate_field_dict adds errors to ValidationResult"""
         from cumulusci.tasks.bulkdata.mapping_parser import ValidationResult
 
         ms = MappingStep(
@@ -2114,10 +2114,8 @@ def test_validate_field_dict_with_validation_result(self):
         )
 
         assert not result
-        assert len(validation_result.warnings) > 0
-        assert any(
-            "NonexistentField__c" in warning for warning in validation_result.warnings
-        )
+        assert validation_result.has_errors()
+        assert any("NonexistentField__c" in error for error in validation_result.errors)
 
     def test_infer_and_validate_lookups_with_validation_result(self):
         """Test _infer_and_validate_lookups adds errors to ValidationResult"""
@@ -2235,10 +2233,11 @@ def test_validate_field_dict_permission_error_with_validation_result(self):
         )
 
         assert not result
-        # Should have warning about incorrect permissions
+        assert validation_result.has_errors()
+        # Should have error about incorrect permissions
         assert any(
-            "does not have the correct permissions" in warning
-            for warning in validation_result.warnings
+            "does not have the correct permissions" in error
+            for error in validation_result.errors
         )
 
     def test_validate_sobject_permission_error_with_validation_result(self):
@@ -2261,10 +2260,11 @@ def test_validate_sobject_permission_error_with_validation_result(self):
         )
 
         assert not result
-        # Should have warning about incorrect permissions
+        assert validation_result.has_errors()
+        # Should have error about incorrect permissions
         assert any(
-            "does not have the correct permissions" in warning
-            for warning in validation_result.warnings
+            "does not have the correct permissions" in error
+            for error in validation_result.errors
         )
 
     def test_infer_and_validate_lookups_invalid_reference_with_validation_result(self):