Merge branch 'main' into feature/select_records

aditya-balachander · web-flow · commit 9d01b941f503 · 2024-09-30T19:19:12.000+05:30
diff --git a/.github/workflows/feature_test.yml b/.github/workflows/feature_test.yml
@@ -19,7 +19,7 @@ jobs:
         runs-on: SFDO-Tooling-Ubuntu
         steps:
             - name: "Checkout"
-              uses: actions/checkout@v2
+              uses: actions/checkout@v4
               with:
                   fetch-depth: 1
             - name: Set up Python 3.8
@@ -49,7 +49,7 @@ jobs:
                     - os: macos-13
                       python-version: 3.8
         steps:
-            - uses: actions/checkout@v2
+            - uses: actions/checkout@v4
             - name: Set up Python
               uses: actions/setup-python@v4
               with:
@@ -65,7 +65,7 @@ jobs:
         name: "Robot: No browser"
         runs-on: SFDO-Tooling-Ubuntu
         steps:
-            - uses: actions/checkout@v2
+            - uses: actions/checkout@v4
             - name: Set up Python 3.8
               uses: actions/setup-python@v4
               with:
@@ -81,9 +81,9 @@ jobs:
                   echo $(realpath sfdx/bin) >> $GITHUB_PATH
             - name: Authenticate Dev Hub
               run: |
-                  sfdx plugins --core
+                  sf plugins --core
                   echo $SFDX_HUB_KEY_BASE64 | base64 --decode > sfdx.key
-                  sfdx auth:jwt:grant --clientid $SFDX_CLIENT_ID --jwtkeyfile sfdx.key --username $SFDX_HUB_USERNAME --setdefaultdevhubusername -a hub
+                  sf org login jwt --client-id $SFDX_CLIENT_ID --jwt-key-file sfdx.key --username $SFDX_HUB_USERNAME --setdefaultdevhubusername -a hub
               env:
                   SFDX_HUB_KEY_BASE64: ${{ secrets.SFDX_HUB_KEY_BASE64 }}
                   SFDX_CLIENT_ID: ${{ secrets.SFDX_CLIENT_ID }}
@@ -101,7 +101,7 @@ jobs:
                   cci org scratch_delete dev
             - name: Store robot results
               if: failure()
-              uses: actions/upload-artifact@v1
+              uses: actions/upload-artifact@v4
               with:
                   name: robot
                   path: robot/CumulusCI/results
diff --git a/.github/workflows/slow_integration_tests.yml b/.github/workflows/slow_integration_tests.yml
@@ -84,15 +84,15 @@ jobs:
             - name: Install sfdx
               run: |
                   mkdir sfdx
-                  wget -qO- https://developer.salesforce.com/media/salesforce-cli/sfdx/channels/stable/sfdx-linux-x64.tar.xz | tar xJ -C sfdx --strip-components 1
+                  wget -qO- https://developer.salesforce.com/media/salesforce-cli/sfdx/channels/stable/sf-linux-x64.tar.xz | tar xJ -C sfdx --strip-components 1
                   echo $(realpath sfdx/bin) >> $GITHUB_PATH
             - name: Initialize Browser/Playwright
               run: cci robot install_playwright
             - name: Authenticate Dev Hub
               run: |
                   sfdx plugins --core
                   echo $SFDX_HUB_KEY_BASE64 | base64 --decode > sfdx.key
-                  sfdx auth:jwt:grant --clientid $SFDX_CLIENT_ID --jwtkeyfile sfdx.key --username $SFDX_HUB_USERNAME --setdefaultdevhubusername -a hub
+                  sf org login jwt --client-id $SFDX_CLIENT_ID --jwt-key-file sfdx.key --username $SFDX_HUB_USERNAME --setdefaultdevhubusername -a hub
               env:
                   SFDX_HUB_KEY_BASE64: ${{ secrets.SFDX_HUB_KEY_BASE64 }}
                   SFDX_CLIENT_ID: ${{ secrets.SFDX_CLIENT_ID }}
@@ -110,7 +110,7 @@ jobs:
                   cci org scratch_delete ${{ matrix.org-shape }}
             - name: Store robot results
               if: failure()
-              uses: actions/upload-artifact@v1
+              uses: actions/upload-artifact@v4
               with:
                   name: robot
                   path: robot/CumulusCI/results
diff --git a/cumulusci/__about__.py b/cumulusci/__about__.py
@@ -1 +1 @@
-__version__ = "3.91.0"
+__version__ = "3.92.0"
diff --git a/cumulusci/robotframework/form_handlers.py b/cumulusci/robotframework/form_handlers.py
@@ -160,7 +160,12 @@ def clear(self):
 class LightningInputHandler(BaseFormHandler):
     """An input handler for components that can be treated as an input or textarea"""
 
-    tags = ["lightning-input", "lightning-textarea", "lightning-datepicker"]
+    tags = [
+        "lightning-primitive-input-checkbox",
+        "lightning-primitive-input-simple",
+        "lightning-textarea",
+        "lightning-datepicker",
+    ]
 
     def set(self, value):
         self.focus()
diff --git a/cumulusci/tasks/preflight/permsets.py b/cumulusci/tasks/preflight/permsets.py
@@ -9,11 +9,14 @@ def _run_task(self):
         for result in self.sf.query_all(query)["records"]:
             if result["PermissionSet"]["Name"] not in self.return_values:
                 self.return_values.append(result["PermissionSet"]["Name"])
-
             if result["PermissionSetGroupId"] is not None:
                 psg_query = f"SELECT PermissionSet.Name from PermissionSetGroupComponent where PermissionSetGroupId = '{result['PermissionSetGroupId']}'"
                 for psg_result in self.sf.query_all(psg_query)["records"]:
-                    if psg_result["PermissionSet"]["Name"] not in self.return_values:
+                    if (
+                        psg_result["PermissionSet"]
+                        and psg_result["PermissionSet"]["Name"]
+                        not in self.return_values
+                    ):
                         self.return_values.append(psg_result["PermissionSet"]["Name"])
 
         permsets_str = "\n".join(self.return_values)
diff --git a/cumulusci/tasks/salesforce/EnsureRecordTypes.py b/cumulusci/tasks/salesforce/EnsureRecordTypes.py
@@ -1,5 +1,6 @@
 import os
 import re
+from xml.sax.saxutils import escape
 
 from cumulusci.core.exceptions import TaskOptionsError
 from cumulusci.core.utils import process_bool_arg
@@ -152,7 +153,7 @@ def _build_package(self):
                     record_type_developer_name=self.options[
                         "record_type_developer_name"
                     ],
-                    stage_name=self.options["stage_name"],
+                    stage_name=escape(self.options["stage_name"]),
                     default=default,
                 )
                 business_process_link = BUSINESS_PROCESS_LINK.format(
diff --git a/cumulusci/tasks/salesforce/tests/test_EnsureRecordTypes.py b/cumulusci/tasks/salesforce/tests/test_EnsureRecordTypes.py
@@ -15,7 +15,7 @@
         <fullName>NPSP_Default</fullName>
         <isActive>true</isActive>
         <values>
-            <fullName>Test</fullName>
+            <fullName>Identify &amp; Qualify</fullName>
             <default>false</default>
         </values>
     </businessProcesses>
@@ -79,7 +79,7 @@
             "name": "StageName",
             "picklistValues": [
                 {"value": "Bad", "active": False},
-                {"value": "Test", "active": True},
+                {"value": "Identify & Qualify", "active": True},
             ],
         },
     ],
@@ -134,7 +134,7 @@ def test_infers_correct_business_process(self):
 
         assert task.options["generate_business_process"]
         assert task.options["generate_record_type"]
-        assert task.options["stage_name"] == "Test"
+        assert task.options["stage_name"] == "Identify & Qualify"
 
     def test_no_business_process_where_unneeded(self):
         task = create_task(
@@ -178,7 +178,6 @@ def test_generates_record_type_and_business_process(self):
             with open(os.path.join("objects", "Opportunity.object"), "r") as f:
                 opp_contents = f.read()
                 assert OPPORTUNITY_METADATA == opp_contents
-                assert OPPORTUNITY_METADATA == opp_contents
             with open(os.path.join("package.xml"), "r") as f:
                 pkg_contents = f.read()
                 assert PACKAGE_XML == pkg_contents
@@ -203,8 +202,8 @@ def test_generates_record_type_and_business_process__case(self):
         with temporary_dir():
             task._build_package()
             with open(os.path.join("objects", "Case.object"), "r") as f:
-                opp_contents = f.read()
-                assert CASE_METADATA == opp_contents
+                case_contents = f.read()
+                assert CASE_METADATA == case_contents
             with open(os.path.join("package.xml"), "r") as f:
                 pkg_contents = f.read()
                 assert PACKAGE_XML == pkg_contents
diff --git a/docs/history.md b/docs/history.md
@@ -2,6 +2,24 @@
 
 <!-- latest-start -->
 
+## v3.92.0 (2024-09-18)
+
+<!-- Release notes generated using configuration in .github/release.yml at main -->
+
+## What's Changed
+
+### Changes 🎉
+
+-   fix: Update input handlers with new Salesforce lightning-primitive tags by [@chanyahn-st](https://github.com/chanyahn-st) in [#3822](https://github.com/SFDO-Tooling/CumulusCI/pull/3822)
+
+## New Contributors
+
+-   @chanyahn-st made their first contribution in [#3822](https://github.com/SFDO-Tooling/CumulusCI/pull/3822)
+
+**Full Changelog**: https://github.com/SFDO-Tooling/CumulusCI/compare/v3.91.0...v3.92.0
+
+<!-- latest-stop -->
+
 ## v3.91.0 (2024-08-22)
 
 <!-- Release notes generated using configuration in .github/release.yml at main -->
@@ -14,8 +32,6 @@
 
 **Full Changelog**: https://github.com/SFDO-Tooling/CumulusCI/compare/v3.90.1...v3.91.0
 
-<!-- latest-stop -->
-
 ## v3.90.1 (2024-08-20)
 
 <!-- Release notes generated using configuration in .github/release.yml at main -->
diff --git a/requirements/dev.txt b/requirements/dev.txt
diff --git a/requirements/prod.txt b/requirements/prod.txt

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-__version__ = "3.91.0"`
	`1`	`+__version__ = "3.92.0"`