feat: update cci robot install_playwright to support uv

Author: jstvz

.github/workflows/slow_integration_tests.yml

@@ -91,9 +91,7 @@ jobs:
                   wget -qO- https://developer.salesforce.com/media/salesforce-cli/sf/channels/stable/sf-linux-x64.tar.xz | tar xJ -C sfdx --strip-components 1
                   echo $(realpath sfdx/bin) >> $GITHUB_PATH
             - name: Initialize Browser/Playwright
-              run: |
-                  uv pip install robotframework-browser
-                  uv run python -m Browser.entry init
+              run: uv run cci robot install_playwright
             - name: Authenticate Dev Hub
               run: |
                   sf plugins --core

cumulusci/cli/robot.py

@@ -1,4 +1,5 @@
 import importlib.metadata
+import shutil
 import sys
 
 import click
@@ -37,9 +38,19 @@ def robot_install_playwright(runtime, dry_run):
 def robot_uninstall_playwright():
     """Attempt to uninstall playwright"""
     p1 = sarge.Command([sys.executable, "-m", "Browser.entry", "clean-node"])
-    p2 = sarge.Command(
-        [sys.executable, "-m", "pip", "uninstall", "robotframework-browser", "--yes"]
-    )
+    if shutil.which("uv"):
+        p2 = sarge.Command(["uv", "pip", "uninstall", "robotframework-browser"])
+    else:
+        p2 = sarge.Command(
+            [
+                sys.executable,
+                "-m",
+                "pip",
+                "uninstall",
+                "robotframework-browser",
+                "--yes",
+            ]
+        )
 
     click.echo("removing node modules...")
     click.echo(f"running {' '.join(p1.args)}")
@@ -53,7 +64,11 @@ def robot_uninstall_playwright():
 
 
 def _install_browser_library(dry_run=False):
-    pip_cmd = [sys.executable, "-m", "pip", "install", "robotframework-browser"]
+    if shutil.which("uv"):
+        pip_cmd = ["uv", "pip", "install", "robotframework-browser"]
+    else:
+        pip_cmd = [sys.executable, "-m", "pip", "install", "robotframework-browser"]
+
     click.echo("installing robotframework-browser ...")
     if dry_run:
         click.echo(f"would run {' '.join(pip_cmd)}")

cumulusci/cli/tests/test_robot.py

@@ -57,9 +57,11 @@ def test_is_package_installed(mock_distribution):
     assert result is False
 
 
+@mock.patch("cumulusci.cli.robot.shutil.which")
 @mock.patch("cumulusci.cli.robot.sarge")
-def test_happy_path(sarge):
+def test_happy_path(sarge, which):
     """Verify the happy path is indeed happy"""
+    which.return_value = False
     sarge.Command.side_effect = mock_Command()
     with mock.patch("cumulusci.cli.robot._is_package_installed", return_value=False):
         run_cli_command("robot", "install_playwright")
@@ -80,6 +82,30 @@ def test_happy_path(sarge):
         assert actual_calls == expected_calls, msg
 
 
+@mock.patch("cumulusci.cli.robot.shutil.which")
+@mock.patch("cumulusci.cli.robot.sarge")
+def test_happy_path_uv(sarge, which):
+    """Verify the happy path is indeed happy with uv"""
+    which.return_value = True
+    sarge.Command.side_effect = mock_Command()
+    with mock.patch("cumulusci.cli.robot._is_package_installed", return_value=False):
+        run_cli_command("robot", "install_playwright")
+        actual_calls = [call.args[0] for call in sarge.Command.mock_calls]
+        expected_calls = [
+            "npm --version",
+            [
+                "uv",
+                "pip",
+                "install",
+                "robotframework-browser",
+            ],
+            [sys.executable, "-m", "Browser.entry", "init"],
+        ]
+        msg = f"\n-- expected --\n{expected_calls}\n\n-- actual --\n{actual_calls}"
+
+        assert actual_calls == expected_calls, msg
+
+
 @mock.patch("sys.exit")
 def test_bogus_subcommand(sys_exit):
     """Verify a bogus subcommand returns a UsageError"""
@@ -100,9 +126,11 @@ def test_no_npm(sarge):
     assert sarge.Command.mock_calls[0].args[0] == "npm --version"
 
 
+@mock.patch("cumulusci.cli.robot.shutil.which")
 @mock.patch("cumulusci.cli.robot.sarge")
-def test_playwright_dry_run(sarge):
+def test_playwright_dry_run(sarge, which):
     """Verify the output of a dry run"""
+    which.return_value = False
     sarge.Command.side_effect = mock_Command(returncodes={"npm --version": 0})
     with mock.patch("cumulusci.cli.robot._is_package_installed", return_value=False):
         result = run_cli_command("robot", "install_playwright", "--dry_run")
@@ -130,9 +158,11 @@ def test_playwright_failure_to_initialize_browser_library(sarge):
             run_cli_command("robot", "install_playwright")
 
 
+@mock.patch("cumulusci.cli.robot.shutil.which")
 @mock.patch("cumulusci.cli.robot.sarge")
-def test_playwright_failure_to_install_browser_library(sarge):
+def test_playwright_failure_to_install_browser_library(sarge, which):
     """Verify we raise an exception if we can't install playwright"""
+    which.return_value = False
     cmd = str([sys.executable, "-m", "pip", "install", "robotframework-browser"])
     sarge.Command.side_effect = mock_Command(returncodes={cmd: 1})
     with mock.patch("cumulusci.cli.robot._is_package_installed", return_value=False):
@@ -154,9 +184,11 @@ def test_playwright_already_installed(sarge):
         )
 
 
+@mock.patch("cumulusci.cli.robot.shutil.which")
 @mock.patch("cumulusci.cli.robot.sarge")
-def test_uninstall_playwright(sarge):
+def test_uninstall_playwright(sarge, which):
     """Verify calling 'robot uninstall_playwright' calls the right utilities"""
+    which.return_value = False
     sarge.Command.side_effect = mock_Command()
     with mock.patch("cumulusci.cli.robot._is_package_installed", return_value=False):
         run_cli_command("robot", "uninstall_playwright")