Skip to content

Commit c4e0076

Browse files
committed
Fix similar for VectorOfArray when both type and dims are specified
Signed-off-by: ErikQQY <2283984853@qq.com>
1 parent 8ff79f5 commit c4e0076

1 file changed

Lines changed: 1 addition & 10 deletions

File tree

src/vector_of_array.jl

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -735,7 +735,7 @@ end
735735
VectorOfArray([similar(VA[:, i], T) for i in eachindex(VA.u)])
736736
end
737737

738-
@inline function Base.similar(VA::VectorOfArray, dims::N) where {N}
738+
@inline function Base.similar(VA::VectorOfArray, dims::N) where {N <: Number}
739739
l = length(VA)
740740
if dims <= l
741741
VectorOfArray([similar(VA[:, i]) for i in 1:l])
@@ -744,15 +744,6 @@ end
744744
end
745745
end
746746

747-
@inline function Base.similar(VA::VectorOfArray, ::Type{T}, dims::N) where {N, T}
748-
l = length(VA)
749-
if dims <= l
750-
VectorOfArray([similar(VA[:, i], T) for i in 1:l])
751-
else
752-
VectorOfArray([[similar(VA[:, i], T) for i in 1:l]; [similar(VA.u[end], T) for _ in (l+1):dims]])
753-
end
754-
end
755-
756747
@inline function Base.similar(VA::VectorOfArray{T, N, AT},
757748
dims::Tuple) where {T, N, AT <: AbstractArray{<:AbstractArray{T}}}
758749
VectorOfArray(similar(VA.u, dims))

0 commit comments

Comments
 (0)