Commit 9156c2a
committed
Improve explicit imports hygiene
This PR ensures SciMLDocs follows best practices for explicit imports:
1. Fixed implicit imports in docs/make.jl:
- Explicitly import makedocs, deploydocs, MathJax3, HTML from Documenter
- Changed Documenter.HTML to HTML (now explicitly imported)
2. Fixed implicit imports in docs/make_aggregate.jl:
- Split comma-separated imports into separate lines
- Explicitly import HTML from Documenter
- Fixed incorrect Docs.HTML reference (should be Documenter.HTML)
3. Added ExplicitImports tests:
- Added ExplicitImports to test dependencies in Project.toml
- Created test checking for implicit and stale imports in test/runtests.jl
The main package (src/SciMLDocs.jl) is an empty module with no imports, which is correct.
All changes maintain backward compatibility while improving code clarity.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>1 parent 220228e commit 9156c2a
4 files changed
Lines changed: 15 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
15 | | - | |
| 16 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
2 | 4 | | |
3 | 5 | | |
4 | 6 | | |
| |||
255 | 257 | | |
256 | 258 | | |
257 | 259 | | |
258 | | - | |
| 260 | + | |
259 | 261 | | |
260 | 262 | | |
261 | 263 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
0 commit comments