Skip to content

Commit cdca75e

Browse files
layershifterlevithomason
authored andcommitted
fix(Embed): props renaming (#831)
1 parent d83ddab commit cdca75e

7 files changed

Lines changed: 12 additions & 13 deletions

File tree

docs/app/Examples/modules/Embed/States/EmbedExampleActive.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ export default class EmbedExampleActive extends Component {
1414
<Embed
1515
active={active}
1616
icon='arrow circle down'
17+
id='90Omh7_I8vI'
1718
placeholder='http://semantic-ui.com/images/image-16by9.png'
1819
source='youtube'
19-
sourceId='90Omh7_I8vI'
2020
/>
2121

2222
<Divider hidden />

docs/app/Examples/modules/Embed/Types/EmbedExampleCustom.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const EmbedExampleCustom = () => (
55
<Embed
66
icon='right circle arrow'
77
placeholder='http://semantic-ui.com/images/image-16by9.png'
8-
sourceUrl='http://www.myfav.es/jack'
8+
url='http://www.myfav.es/jack'
99
/>
1010
)
1111

docs/app/Examples/modules/Embed/Types/EmbedExampleVimeo.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ import { Embed } from 'semantic-ui-react'
33

44
const EmbedExampleVimeo = () => (
55
<Embed
6+
id='125292332'
67
placeholder='http://semantic-ui.com/images/vimeo-example.jpg'
78
source='vimeo'
8-
sourceId='125292332'
99
/>
1010
)
1111

docs/app/Examples/modules/Embed/Types/EmbedExampleYoutube.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ import { Embed } from 'semantic-ui-react'
33

44
const EmbedExampleYouTube = () => (
55
<Embed
6+
id='O6Xo21L0ybE'
67
placeholder='http://semantic-ui.com/images/image-16by9.png'
78
source='youtube'
8-
sourceId='O6Xo21L0ybE'
99
/>
1010
)
1111

docs/app/Examples/modules/Embed/Usage/EmbedExampleSettings.js

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,13 @@ import { Embed } from 'semantic-ui-react'
33

44
const EmbedExampleSettings = () => (
55
<Embed
6+
autoplay={false}
7+
brandedUI={false}
8+
color='white'
9+
hd={false}
10+
id='D0WnZyxp_Wo'
611
placeholder='http://semantic-ui.com/images/image-16by9.png'
712
source='youtube'
8-
sourceId='D0WnZyxp_Wo'
9-
sourceSettings={{
10-
autoPlay: false,
11-
brandedUI: false,
12-
color: 'white',
13-
hd: false,
14-
}}
1513
/>
1614
)
1715

docs/app/Examples/modules/Embed/Variations/EmbedExampleAspectRatio.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ import { Embed } from 'semantic-ui-react'
44
const EmbedExampleAspectRatio = () => (
55
<Embed
66
aspectRatio='4:3'
7+
id='HTZudKi36bo'
78
placeholder='http://semantic-ui.com/images/4by3.jpg'
89
source='youtube'
9-
sourceId='HTZudKi36bo'
1010
/>
1111
)
1212

src/modules/Embed/Embed.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,8 @@ export default class Embed extends Component {
177177
}
178178

179179
renderEmbed() {
180-
const { active, children } = this.props
180+
const { children } = this.props
181+
const { active } = this.state
181182

182183
if (!active) return null
183184
if (children) return <div className='embed'>{children}</div>

0 commit comments

Comments
 (0)