From 2c9b308965a6f834c77b24607afea94965fd3146 Mon Sep 17 00:00:00 2001 From: Juan Mantica Date: Fri, 22 May 2026 16:34:04 -0400 Subject: [PATCH 1/3] feat(scol): validate oauth2 token_url scheme at vector validate time Call Config::validate_auth() synchronously in SourceConfig::build() before boxing the source future, so vector validate catches invalid token_url values at the Component configuration step rather than silently deferring to runtime. Bump lib/observo/private to ef53ab5 which adds SAuth::validate() and Config::validate_auth() in the dataplane-private submodule. --- lib/observo/private | 2 +- src/sources/scol/mod.rs | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/observo/private b/lib/observo/private index f6ab256f4..ef53ab5c9 160000 --- a/lib/observo/private +++ b/lib/observo/private @@ -1 +1 @@ -Subproject commit f6ab256f40465471bcb7acf15880f8e07934c561 +Subproject commit ef53ab5c9b4ddf5cbcde651c69df86590fe3677d diff --git a/src/sources/scol/mod.rs b/src/sources/scol/mod.rs index 1e12ef700..19016b76f 100644 --- a/src/sources/scol/mod.rs +++ b/src/sources/scol/mod.rs @@ -19,6 +19,7 @@ use crate::config::{SourceConfig, SourceContext}; #[typetag::serde(name = "scol")] impl SourceConfig for Config { async fn build(&self, cx: SourceContext) -> Result { + self.validate_auth()?; let lns = cx.log_namespace(self.log_namespace); let chkptr = cx.checkpoint_accessor().await; let src = self From f915899b724a6f2e059105a92a8ee1f93603d9d2 Mon Sep 17 00:00:00 2001 From: Juan Mantica Date: Tue, 26 May 2026 12:41:44 -0400 Subject: [PATCH 2/3] chore: bump lib/observo/private to pick up oauth2 token_url validation --- lib/observo/private | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/observo/private b/lib/observo/private index ef53ab5c9..205b911f7 160000 --- a/lib/observo/private +++ b/lib/observo/private @@ -1 +1 @@ -Subproject commit ef53ab5c9b4ddf5cbcde651c69df86590fe3677d +Subproject commit 205b911f71bdcff004a20e069b5edc014c7cebb8 From 50f77b1580b26f0a59933d6440463a6673784a3c Mon Sep 17 00:00:00 2001 From: Juan Mantica Date: Tue, 26 May 2026 12:44:53 -0400 Subject: [PATCH 3/3] revert: remove validate_auth() call, validation is now in serde --- src/sources/scol/mod.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/sources/scol/mod.rs b/src/sources/scol/mod.rs index 19016b76f..1e12ef700 100644 --- a/src/sources/scol/mod.rs +++ b/src/sources/scol/mod.rs @@ -19,7 +19,6 @@ use crate::config::{SourceConfig, SourceContext}; #[typetag::serde(name = "scol")] impl SourceConfig for Config { async fn build(&self, cx: SourceContext) -> Result { - self.validate_auth()?; let lns = cx.log_namespace(self.log_namespace); let chkptr = cx.checkpoint_accessor().await; let src = self