Delete IPath.Length

Author: JimBobSquarePants

src/ImageSharp.Drawing/Shapes/ComplexPolygon.cs

@@ -20,6 +20,7 @@ public sealed class ComplexPolygon : IPath, IPathInternals, IInternalPathOwner
         private readonly IPath[] paths;
         private readonly List<InternalPath> internalPaths;
         private readonly int maxIntersections;
+        private readonly float length;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="ComplexPolygon" /> class.
@@ -52,7 +53,6 @@ public ComplexPolygon(params IPath[] paths)
 
                 foreach (IPath p in this.paths)
                 {
-                    length += p.Length;
                     if (p.Bounds.Left < minX)
                     {
                         minX = p.Bounds.Left;
@@ -77,30 +77,25 @@ public ComplexPolygon(params IPath[] paths)
                     {
                         var ip = new InternalPath(s.Points, s.IsClosed);
                         intersections += ip.PointCount;
-
+                        length += ip.Length;
                         this.internalPaths.Add(ip);
                     }
                 }
 
                 this.maxIntersections = intersections;
-                this.Length = length;
+                this.length = length;
                 this.Bounds = new RectangleF(minX, minY, maxX - minX, maxY - minY);
             }
             else
             {
                 this.maxIntersections = 0;
-                this.Length = 0;
+                this.length = 0;
                 this.Bounds = RectangleF.Empty;
             }
 
             this.PathType = PathTypes.Mixed;
         }
 
-        /// <summary>
-        /// Gets the length of the path.
-        /// </summary>
-        public float Length { get; }
-
         /// <summary>
         /// Gets a value indicating whether this instance is closed, open or a composite path with a mixture of open and closed figures.
         /// </summary>
@@ -271,7 +266,7 @@ public IPath AsClosedPath()
         /// </returns>
         SegmentInfo IPathInternals.PointAlongPath(float distance)
         {
-            distance %= this.Length;
+            distance %= this.length;
             foreach (InternalPath p in this.internalPaths)
             {
                 if (p.Length >= distance)

src/ImageSharp.Drawing/Shapes/EllipsePolygon.cs

@@ -82,13 +82,8 @@ private EllipsePolygon(CubicBezierLineSegment segment)
         /// </summary>
         PathTypes IPath.PathType => PathTypes.Closed;
 
-        /// <summary>
-        /// Gets the maximum number intersections that a shape can have when testing a line.
-        /// </summary>
-        int IPathInternals.MaxIntersections => this.innerPath.PointCount;
-
         /// <inheritdoc />
-        public float Length => this.innerPath.Length;
+        int IPathInternals.MaxIntersections => this.innerPath.PointCount;
 
         /// <summary>
         /// Transforms the rectangle using specified matrix.

src/ImageSharp.Drawing/Shapes/IPath.cs

@@ -21,23 +21,18 @@ public interface IPath
         /// </summary>
         RectangleF Bounds { get; }
 
-        /// <summary>
-        /// Gets the length of the path.
-        /// </summary>
-        float Length { get; }
-
         /// <summary>
         /// Converts the <see cref="IPath" /> into a simple linear path.
         /// </summary>
         /// <returns>Returns the current <see cref="IPath" /> as simple linear path.</returns>
         IEnumerable<ISimplePath> Flatten();
 
         /// <summary>
-        /// Determines whether the <see cref="IPath"/> contains the specified point
+        /// Determines whether the <see cref="IPath"/> contains the specified point.
         /// </summary>
         /// <param name="point">The point.</param>
         /// <returns>
-        ///   <c>true</c> if the <see cref="IPath"/> contains the specified point; otherwise, <c>false</c>.
+        /// <see langword="true"/> if the <see cref="IPath"/> contains the specified point; otherwise, <see langword="false"/>.
         /// </returns>
         bool Contains(PointF point);
 

src/ImageSharp.Drawing/Shapes/ISimplePath.cs

@@ -1,8 +1,7 @@
-// Copyright (c) Six Labors.
+// Copyright (c) Six Labors.
 // Licensed under the Apache License, Version 2.0.
 
 using System;
-using System.Collections.Generic;
 
 namespace SixLabors.ImageSharp.Drawing
 {
@@ -21,4 +20,4 @@ public interface ISimplePath
         /// </summary>
         ReadOnlyMemory<PointF> Points { get; }
     }
-}
+}

src/ImageSharp.Drawing/Shapes/Path.cs

@@ -42,11 +42,6 @@ public Path(Path path)
         public Path(params ILineSegment[] segments)
             => this.lineSegments = segments ?? throw new ArgumentNullException(nameof(segments));
 
-        /// <summary>
-        /// Gets the length of the path.
-        /// </summary>
-        public float Length => this.InnerPath.Length;
-
         /// <summary>
         /// Gets a value indicating whether this instance is a closed path.
         /// </summary>

src/ImageSharp.Drawing/Shapes/RectangularPolygon.cs

@@ -124,9 +124,6 @@ public RectangularPolygon(RectangleF rectangle)
         /// </summary>
         RectangleF IPath.Bounds => this.bounds;
 
-        /// <inheritdoc />
-        float IPath.Length => this.length;
-
         /// <inheritdoc/>
         int IPathInternals.MaxIntersections => 4;
 

tests/ImageSharp.Drawing.Tests/Drawing/Paths/ShapeRegionTests.cs

@@ -29,8 +29,6 @@ public abstract class MockPath : IPath, IPathInternals
 
             public abstract int MaxIntersections { get; }
 
-            public abstract float Length { get; }
-
             public int FindIntersections(PointF start, PointF end, Span<PointF> intersections, Span<PointOrientation> orientations)
                 => this.FindIntersections(start, end, intersections, orientations, IntersectionRule.OddEven);