Remove MaxIntersections

Author: JimBobSquarePants

src/ImageSharp.Drawing/Shapes/ComplexPolygon.cs

@@ -18,7 +18,6 @@ public sealed class ComplexPolygon : IPath, IPathInternals, IInternalPathOwner
     {
         private readonly IPath[] paths;
         private readonly List<InternalPath> internalPaths;
-        private readonly int maxIntersections;
         private readonly float length;
 
         /// <summary>
@@ -48,7 +47,6 @@ public ComplexPolygon(params IPath[] paths)
                 float minY = float.MaxValue;
                 float maxY = float.MinValue;
                 float length = 0;
-                int intersections = 0;
 
                 foreach (IPath p in this.paths)
                 {
@@ -75,19 +73,16 @@ public ComplexPolygon(params IPath[] paths)
                     foreach (ISimplePath s in p.Flatten())
                     {
                         var ip = new InternalPath(s.Points, s.IsClosed);
-                        intersections += ip.PointCount;
                         length += ip.Length;
                         this.internalPaths.Add(ip);
                     }
                 }
 
-                this.maxIntersections = intersections;
                 this.length = length;
                 this.Bounds = new RectangleF(minX, minY, maxX - minX, maxY - minY);
             }
             else
             {
-                this.maxIntersections = 0;
                 this.length = 0;
                 this.Bounds = RectangleF.Empty;
             }
@@ -106,9 +101,6 @@ public ComplexPolygon(params IPath[] paths)
         /// <inheritdoc/>
         public RectangleF Bounds { get; }
 
-        /// <inheritdoc/>
-        int IPathInternals.MaxIntersections => this.maxIntersections;
-
         /// <inheritdoc/>
         public bool Contains(PointF point)
         {

src/ImageSharp.Drawing/Shapes/EllipsePolygon.cs

@@ -76,9 +76,6 @@ private EllipsePolygon(CubicBezierLineSegment segment)
         /// <inheritdoc/>
         public PathTypes PathType => PathTypes.Closed;
 
-        /// <inheritdoc />
-        int IPathInternals.MaxIntersections => this.innerPath.PointCount;
-
         /// <inheritdoc/>
         public IPath Transform(Matrix3x2 matrix) => matrix.IsIdentity
                   ? this

src/ImageSharp.Drawing/Shapes/IPathInternals.cs

@@ -8,11 +8,6 @@ namespace SixLabors.ImageSharp.Drawing
     /// </summary>
     internal interface IPathInternals : IPath
     {
-        /// <summary>
-        /// Gets the maximum number intersections that a shape can have when testing a line.
-        /// </summary>
-        int MaxIntersections { get; }
-
         /// <summary>
         /// Returns information about a point at a given distance along a path.
         /// </summary>

src/ImageSharp.Drawing/Shapes/Path.cs

@@ -57,8 +57,10 @@ public Path(params ILineSegment[] segments)
         /// <inheritdoc />
         public PathTypes PathType => this.IsClosed ? PathTypes.Open : PathTypes.Closed;
 
-        /// <inheritdoc />
-        public int MaxIntersections => this.InnerPath.PointCount;
+        /// <summary>
+        /// Gets the maximum number intersections that a shape can have when testing a line.
+        /// </summary>
+        internal int MaxIntersections => this.InnerPath.PointCount;
 
         /// <summary>
         /// Gets readonly collection of line segments.

src/ImageSharp.Drawing/Shapes/RectangularPolygon.cs

@@ -121,9 +121,6 @@ public RectangularPolygon(RectangleF rectangle)
         /// <inheritdoc/>
         public RectangleF Bounds { get; private set; }
 
-        /// <inheritdoc/>
-        int IPathInternals.MaxIntersections => 4;
-
         /// <inheritdoc/>
         public bool IsClosed => true;
 

tests/ImageSharp.Drawing.Tests/Drawing/Paths/ShapeRegionTests.cs

@@ -27,8 +27,6 @@ public abstract class MockPath : IPath, IPathInternals
 
             public abstract PathTypes PathType { get; }
 
-            public abstract int MaxIntersections { get; }
-
             public int TestFindIntersectionsInvocationCounter { get; private set; }
 
             public virtual int TestYToScan => 10;

tests/ImageSharp.Drawing.Tests/Shapes/RectangleTests.cs

@@ -144,13 +144,6 @@ public void Bounds_Path()
             Assert.Equal(24, shape.Bounds.Bottom);
         }
 
-        [Fact]
-        public void MaxIntersections_Shape()
-        {
-            IPathInternals shape = new RectangularPolygon(10, 11, 12, 13);
-            Assert.Equal(4, shape.MaxIntersections);
-        }
-
         [Fact]
         public void ShapePaths()
         {