Fix warnings

Author: brianpopow

.editorconfig

@@ -75,7 +75,7 @@ indent_style = tab
 
 [*.{cs,csx,cake,vb,vbx}]
 # Default Severity for all .NET Code Style rules below
-dotnet_analyzer_diagnostic.severity = warning
+dotnet_analyzer_diagnostic.category-style.severity = warning
 
 ##########################################
 # Language Rules

src/ImageSharp.Drawing/Common/Extensions/GraphicsOptionsExtensions.cs

@@ -2,7 +2,6 @@
 // Licensed under the Apache License, Version 2.0.
 
 using System.Numerics;
-using SixLabors.ImageSharp.Drawing.Processing;
 using SixLabors.ImageSharp.PixelFormats;
 
 namespace SixLabors.ImageSharp.Drawing

src/ImageSharp.Drawing/Processing/Brushes.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Six Labors.
+// Copyright (c) Six Labors.
 // Licensed under the Apache License, Version 2.0.
 
 namespace SixLabors.ImageSharp.Drawing.Processing
@@ -219,4 +219,4 @@ public static PatternBrush BackwardDiagonal(Color foreColor) =>
         public static PatternBrush BackwardDiagonal(Color foreColor, Color backColor) =>
             new PatternBrush(foreColor, backColor, BackwardDiagonalPattern);
     }
-}
+}

src/ImageSharp.Drawing/Processing/ColorStop.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Six Labors.
+// Copyright (c) Six Labors.
 // Licensed under the Apache License, Version 2.0.
 
 using System.Diagnostics;
@@ -32,4 +32,4 @@ public ColorStop(float ratio, in Color color)
         /// </summary>
         public Color Color { get; }
     }
-}
+}

src/ImageSharp.Drawing/Processing/DrawingOptions.cs

@@ -1,10 +1,7 @@
 // Copyright (c) Six Labors.
 // Licensed under the Apache License, Version 2.0.
 
-using System;
 using System.Numerics;
-using SixLabors.ImageSharp.PixelFormats;
-using SixLabors.ImageSharp.Processing;
 
 namespace SixLabors.ImageSharp.Drawing.Processing
 {

src/ImageSharp.Drawing/Processing/GradientBrush.cs

@@ -2,9 +2,7 @@
 // Licensed under the Apache License, Version 2.0.
 
 using System;
-using System.Buffers;
 using System.Numerics;
-using System.Threading;
 using SixLabors.ImageSharp.Drawing.Utilities;
 using SixLabors.ImageSharp.Memory;
 using SixLabors.ImageSharp.PixelFormats;
@@ -197,7 +195,7 @@ protected override void Dispose(bool disposing)
                 this.isDisposed = true;
             }
 
-            private (ColorStop from, ColorStop to) GetGradientSegment(float positionOnCompleteGradient)
+            private (ColorStop From, ColorStop To) GetGradientSegment(float positionOnCompleteGradient)
             {
                 ColorStop localGradientFrom = this.colorStops[0];
                 ColorStop localGradientTo = default;

src/ImageSharp.Drawing/Processing/GradientRepetitionMode.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Six Labors.
+// Copyright (c) Six Labors.
 // Licensed under the Apache License, Version 2.0.
 
 namespace SixLabors.ImageSharp.Drawing.Processing
@@ -34,4 +34,4 @@ public enum GradientRepetitionMode
         /// </summary>
         DontFill
     }
-}
+}

src/ImageSharp.Drawing/Processing/IPen.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Six Labors.
+// Copyright (c) Six Labors.
 // Licensed under the Apache License, Version 2.0.
 
 using System;
@@ -25,4 +25,4 @@ public interface IPen
         /// </summary>
         ReadOnlySpan<float> StrokePattern { get; }
     }
-}
+}

src/ImageSharp.Drawing/Processing/LinearGradientBrush.cs

@@ -2,7 +2,6 @@
 // Licensed under the Apache License, Version 2.0.
 
 using System;
-
 using SixLabors.ImageSharp.PixelFormats;
 
 namespace SixLabors.ImageSharp.Drawing.Processing

src/ImageSharp.Drawing/Processing/PathGradientBrush.cs

@@ -2,13 +2,10 @@
 // Licensed under the Apache License, Version 2.0.
 
 using System;
-using System.Buffers;
 using System.Collections.Generic;
 using System.Linq;
 using System.Numerics;
-using System.Threading;
 using SixLabors.ImageSharp.Drawing.Utilities;
-using SixLabors.ImageSharp.Memory;
 using SixLabors.ImageSharp.PixelFormats;
 
 namespace SixLabors.ImageSharp.Drawing.Processing
@@ -114,7 +111,7 @@ private static Color CalculateCenterColor(Color[] colors)
 
         private static float DistanceBetween(PointF p1, PointF p2) => ((Vector2)(p2 - p1)).Length();
 
-        private struct Intersection
+        private readonly struct Intersection
         {
             public Intersection(PointF point, float distance)
             {
@@ -189,7 +186,7 @@ private sealed class PathGradientBrushApplicator<TPixel> : BrushApplicator<TPixe
 
             private readonly TPixel transparentPixel;
 
-            private ThreadLocalBlenderBuffers<TPixel> blenderBuffers;
+            private readonly ThreadLocalBlenderBuffers<TPixel> blenderBuffers;
 
             private bool isDisposed;
 
@@ -218,7 +215,7 @@ public PathGradientBrushApplicator(
                 this.centerColor = (Vector4)centerColor;
                 this.hasSpecialCenterColor = hasSpecialCenterColor;
                 this.centerPixel = centerColor.ToPixel<TPixel>();
-                this.maxDistance = points.Select(p => (Vector2)(p - this.center)).Max(d => d.Length());
+                this.maxDistance = points.Select(p => p - this.center).Max(d => d.Length());
                 this.transparentPixel = Color.Transparent.ToPixel<TPixel>();
                 this.blenderBuffers = new ThreadLocalBlenderBuffers<TPixel>(configuration.MemoryAllocator, source.Width);
             }
@@ -259,15 +256,15 @@ public PathGradientBrushApplicator(
                     var direction = Vector2.Normalize(point - this.center);
                     Vector2 end = point + (direction * this.maxDistance);
 
-                    (Edge edge, Vector2 point)? isc = this.FindIntersection(point, end);
+                    (Edge Edge, Vector2 Point)? isc = this.FindIntersection(point, end);
 
                     if (!isc.HasValue)
                     {
                         return this.transparentPixel;
                     }
 
-                    Vector2 intersection = isc.Value.point;
-                    Vector4 edgeColor = isc.Value.edge.ColorAt(intersection);
+                    Vector2 intersection = isc.Value.Point;
+                    Vector4 edgeColor = isc.Value.Edge.ColorAt(intersection);
 
                     float length = DistanceBetween(intersection, this.center);
                     float ratio = length > 0 ? DistanceBetween(intersection, point) / length : 0;
@@ -327,7 +324,7 @@ protected override void Dispose(bool disposing)
                 this.isDisposed = true;
             }
 
-            private (Edge edge, Vector2 point)? FindIntersection(
+            private (Edge Edge, Vector2 Point)? FindIntersection(
                 PointF start,
                 PointF end)
             {
@@ -350,7 +347,7 @@ protected override void Dispose(bool disposing)
                     }
                 }
 
-                return closestEdge != null ? (closestEdge, closestIntersection) : ((Edge edge, Vector2 point)?)null;
+                return closestEdge != null ? (closestEdge, closestIntersection) : ((Edge Edge, Vector2 Point)?)null;
             }
 
             private static bool FindPointOnTriangle(Vector2 v1, Vector2 v2, Vector2 v3, Vector2 point, out float u, out float v)