Remove FillPath API from drawing backends

Author: JimBobSquarePants

src/ImageSharp.Drawing.WebGPU/WebGPUDrawingBackend.cs

@@ -142,26 +142,6 @@ internal bool TryGetInteropHandles(out nint deviceHandle, out nint queueHandle)
         return false;
     }
 
-    /// <inheritdoc />
-    public void FillPath<TPixel>(
-        ICanvasFrame<TPixel> target,
-        IPath path,
-        Brush brush,
-        GraphicsOptions graphicsOptions,
-        in RasterizerOptions rasterizerOptions,
-        DrawingCanvasBatcher<TPixel> batcher)
-        where TPixel : unmanaged, IPixel<TPixel>
-    {
-        this.ThrowIfDisposed();
-        batcher.AddComposition(
-            CompositionCommand.Create(
-                path,
-                brush,
-                graphicsOptions,
-                rasterizerOptions,
-                target.Bounds.Location));
-    }
-
     /// <inheritdoc />
     public void FlushCompositions<TPixel>(
         Configuration configuration,

src/ImageSharp.Drawing/Processing/Backends/DefaultDrawingBackend.cs

@@ -38,18 +38,6 @@ internal sealed class DefaultDrawingBackend : IDrawingBackend
     /// </summary>
     public static DefaultDrawingBackend Instance { get; } = new();
 
-    /// <inheritdoc />
-    public void FillPath<TPixel>(
-        ICanvasFrame<TPixel> target,
-        IPath path,
-        Brush brush,
-        GraphicsOptions graphicsOptions,
-        in RasterizerOptions rasterizerOptions,
-        DrawingCanvasBatcher<TPixel> batcher)
-        where TPixel : unmanaged, IPixel<TPixel>
-        => batcher.AddComposition(
-            CompositionCommand.Create(path, brush, graphicsOptions, rasterizerOptions, target.Bounds.Location));
-
     /// <inheritdoc />
     public void FlushCompositions<TPixel>(
         Configuration configuration,

src/ImageSharp.Drawing/Processing/Backends/IDrawingBackend.cs

@@ -14,25 +14,6 @@ namespace SixLabors.ImageSharp.Drawing.Processing.Backends;
 /// </remarks>
 internal interface IDrawingBackend
 {
-    /// <summary>
-    /// Fills a path into a destination target region.
-    /// </summary>
-    /// <typeparam name="TPixel">The pixel format.</typeparam>
-    /// <param name="target">Destination frame.</param>
-    /// <param name="path">Path in target-local coordinates.</param>
-    /// <param name="brush">Brush used to shade covered pixels.</param>
-    /// <param name="graphicsOptions">Graphics blending/composition options.</param>
-    /// <param name="rasterizerOptions">Rasterizer options in target-local coordinates.</param>
-    /// <param name="batcher">Batcher used to queue normalized composition commands.</param>
-    public void FillPath<TPixel>(
-        ICanvasFrame<TPixel> target,
-        IPath path,
-        Brush brush,
-        GraphicsOptions graphicsOptions,
-        in RasterizerOptions rasterizerOptions,
-        DrawingCanvasBatcher<TPixel> batcher)
-        where TPixel : unmanaged, IPixel<TPixel>;
-
     /// <summary>
     /// Flushes queued composition operations for the target.
     /// </summary>

src/ImageSharp.Drawing/Processing/DrawingCanvas{TPixel}.cs

@@ -351,7 +351,7 @@ public void Fill(IPath path, Brush brush)
 
         transformedPath = ApplyClipPaths(transformedPath, effectiveOptions.ShapeOptions, state.ClipPaths);
 
-        this.FillPathCore(transformedPath, brush, effectiveOptions, RasterizerSamplingOrigin.PixelBoundary);
+        this.PrepareCompositionCore(transformedPath, brush, effectiveOptions, RasterizerSamplingOrigin.PixelBoundary);
     }
 
     /// <inheritdoc />
@@ -407,7 +407,7 @@ public void Process(IPath path, Action<IImageProcessingContext> operation)
         ImageBrush brush = new(sourceImage, sourceImage.Bounds, brushOffset);
 
         this.pendingImageResources.Add(sourceImage);
-        this.FillPathCore(transformedPath, brush, effectiveOptions, RasterizerSamplingOrigin.PixelBoundary);
+        this.PrepareCompositionCore(transformedPath, brush, effectiveOptions, RasterizerSamplingOrigin.PixelBoundary);
     }
 
     /// <inheritdoc />
@@ -480,7 +480,7 @@ public void Draw(Pen pen, IPath path)
 
         outline = ApplyClipPaths(outline, effectiveOptions.ShapeOptions, state.ClipPaths);
 
-        this.FillPathCore(outline, pen.StrokeFill, effectiveOptions, RasterizerSamplingOrigin.PixelCenter);
+        this.PrepareCompositionCore(outline, pen.StrokeFill, effectiveOptions, RasterizerSamplingOrigin.PixelCenter);
     }
 
     /// <inheritdoc />
@@ -813,13 +813,13 @@ private void DrawImageCore(
     }
 
     /// <summary>
-    /// Rasterizes and submits a fill operation to the backend.
+    /// Prepares a path fill composition command and enqueues it in the batcher.
     /// </summary>
     /// <param name="path">Path to fill.</param>
     /// <param name="brush">Brush used for shading.</param>
     /// <param name="options">Effective drawing options.</param>
     /// <param name="samplingOrigin">Rasterizer sampling origin.</param>
-    private void FillPathCore(
+    private void PrepareCompositionCore(
         IPath path,
         Brush brush,
         DrawingOptions options,
@@ -849,13 +849,13 @@ private void FillPathCore(
             samplingOrigin,
             graphicsOptions.AntialiasThreshold);
 
-        this.backend.FillPath(
-            this.targetFrame,
-            path,
-            brush,
-            graphicsOptions,
-            rasterizerOptions,
-            this.batcher);
+        this.batcher.AddComposition(
+            CompositionCommand.Create(
+                path,
+                brush,
+                graphicsOptions,
+                rasterizerOptions,
+                this.targetFrame.Bounds.Location));
     }
 
     /// <summary>

tests/ImageSharp.Drawing.Tests/Processing/Backends/SkiaCoverageDrawingBackend.cs

@@ -26,22 +26,6 @@ internal sealed class SkiaCoverageDrawingBackend : IDrawingBackend, IDisposable
 
     public int LiveCoverageCount => this.preparedCoverage.Count;
 
-    public void FillPath<TPixel>(
-        ICanvasFrame<TPixel> target,
-        IPath path,
-        Brush brush,
-        GraphicsOptions graphicsOptions,
-        in RasterizerOptions rasterizerOptions,
-        DrawingCanvasBatcher<TPixel> batcher)
-        where TPixel : unmanaged, IPixel<TPixel>
-        => batcher.AddComposition(
-            CompositionCommand.Create(
-                path,
-                brush,
-                graphicsOptions,
-                rasterizerOptions,
-                target.Bounds.Location));
-
     public void FlushCompositions<TPixel>(
         Configuration configuration,
         ICanvasFrame<TPixel> target,

tests/ImageSharp.Drawing.Tests/Processing/DrawingCanvasBatcherTests.cs

@@ -55,17 +55,6 @@ private sealed class CapturingBackend : IDrawingBackend
                     0.5f)),
             Array.Empty<PreparedCompositionCommand>());
 
-        public void FillPath<TPixel>(
-            ICanvasFrame<TPixel> target,
-            IPath path,
-            Brush brush,
-            GraphicsOptions graphicsOptions,
-            in RasterizerOptions rasterizerOptions,
-            DrawingCanvasBatcher<TPixel> batcher)
-            where TPixel : unmanaged, IPixel<TPixel>
-            => batcher.AddComposition(
-                CompositionCommand.Create(path, brush, graphicsOptions, rasterizerOptions, target.Bounds.Location));
-
         public void FlushCompositions<TPixel>(
             Configuration configuration,
             ICanvasFrame<TPixel> target,

tests/ImageSharp.Drawing.Tests/Processing/DrawingCanvasTests.Process.cs

@@ -151,17 +151,6 @@ public MirroringCpuReadbackTestBackend(ICanvasFrame<TPixel> proxyFrame, Image<TP
 
         public Configuration? LastReadbackConfiguration { get; private set; }
 
-        public void FillPath<TTargetPixel>(
-            ICanvasFrame<TTargetPixel> target,
-            IPath path,
-            Brush brush,
-            GraphicsOptions graphicsOptions,
-            in RasterizerOptions rasterizerOptions,
-            DrawingCanvasBatcher<TTargetPixel> batcher)
-            where TTargetPixel : unmanaged, IPixel<TTargetPixel>
-            => batcher.AddComposition(
-                CompositionCommand.Create(path, brush, graphicsOptions, rasterizerOptions, target.Bounds.Location));
-
         public void FlushCompositions<TTargetPixel>(
             Configuration configuration,
             ICanvasFrame<TTargetPixel> target,

tests/ImageSharp.Drawing.Tests/Processing/RasterizerDefaultsExtensionsTests.cs

@@ -47,17 +47,6 @@ public void SetDrawingBackendOnProcessingContext_RoundTrips()
 
     private sealed class RecordingDrawingBackend : IDrawingBackend
     {
-        public void FillPath<TPixel>(
-            ICanvasFrame<TPixel> target,
-            IPath path,
-            Brush brush,
-            GraphicsOptions graphicsOptions,
-            in RasterizerOptions rasterizerOptions,
-            DrawingCanvasBatcher<TPixel> batcher)
-            where TPixel : unmanaged, IPixel<TPixel>
-        {
-        }
-
         public void FlushCompositions<TPixel>(
             Configuration configuration,
             ICanvasFrame<TPixel> target,