Merge -> Concat

Author: JimBobSquarePants

src/ImageSharp.Drawing/CubicBezierLineSegment.cs

@@ -46,7 +46,7 @@ public CubicBezierLineSegment(PointF[] points)
     /// <param name="end">The end.</param>
     /// <param name="additionalPoints">The additional points.</param>
     public CubicBezierLineSegment(PointF start, PointF controlPoint1, PointF controlPoint2, PointF end, params PointF[] additionalPoints)
-        : this(new[] { start, controlPoint1, controlPoint2, end }.Merge(additionalPoints))
+        : this(new[] { start, controlPoint1, controlPoint2, end }.Concat(additionalPoints))
     {
     }
 

src/ImageSharp.Drawing/Helpers/ArrayExtensions.cs

@@ -9,32 +9,25 @@ namespace SixLabors.ImageSharp.Drawing.Helpers;
 internal static class ArrayExtensions
 {
     /// <summary>
-    /// Merges two arrays into one.
+    /// Concatenates two arrays into one.
     /// </summary>
-    /// <typeparam name="T">the type of the array</typeparam>
+    /// <typeparam name="T">The element type.</typeparam>
     /// <param name="source1">The first source array.</param>
     /// <param name="source2">The second source array.</param>
     /// <returns>
-    /// A new array containing the elements of both source arrays.
+    /// A new array containing the elements of both source arrays, or <paramref name="source1"/>
+    /// when <paramref name="source2"/> is empty.
     /// </returns>
-    public static T[] Merge<T>(this T[] source1, T[] source2)
+    public static T[] Concat<T>(this T[] source1, T[] source2)
     {
         if (source2 is null || source2.Length == 0)
         {
             return source1;
         }
 
         T[] target = new T[source1.Length + source2.Length];
-
-        for (int i = 0; i < source1.Length; i++)
-        {
-            target[i] = source1[i];
-        }
-
-        for (int i = 0; i < source2.Length; i++)
-        {
-            target[i + source1.Length] = source2[i];
-        }
+        source1.AsSpan().CopyTo(target);
+        source2.AsSpan().CopyTo(target.AsSpan(source1.Length));
 
         return target;
     }

src/ImageSharp.Drawing/InternalPath.cs

@@ -379,13 +379,13 @@ private static PointData[] Simplify(ReadOnlySpan<PointF> points, bool isClosed,
     }
 
     /// <summary>
-    /// Merges the specified source2.
+    /// Determines whether two points are within the specified coordinate threshold of one another.
     /// </summary>
-    /// <param name="source1">The source1.</param>
-    /// <param name="source2">The source2.</param>
-    /// <param name="threshold">The threshold.</param>
+    /// <param name="source1">The first point.</param>
+    /// <param name="source2">The second point.</param>
+    /// <param name="threshold">The per-axis distance threshold.</param>
     /// <returns>
-    /// the Merged arrays
+    /// <see langword="true"/> when both coordinates are within <paramref name="threshold"/>; otherwise, <see langword="false"/>.
     /// </returns>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
     private static bool Equivalent(PointF source1, PointF source2, float threshold)

src/ImageSharp.Drawing/LinearLineSegment.cs

@@ -34,7 +34,7 @@ public LinearLineSegment(PointF start, PointF end)
     /// <param name="point2">The point2.</param>
     /// <param name="additionalPoints">Additional points</param>
     public LinearLineSegment(PointF point1, PointF point2, params PointF[] additionalPoints)
-        : this(new[] { point1, point2 }.Merge(additionalPoints))
+        : this(new[] { point1, point2 }.Concat(additionalPoints))
     {
     }