SONARIAC-2199 Improve licensing plugin for use in sonar-php (#78)

Author: jonas-wielage-sonarsource

gradle-modules/src/main/kotlin/org.sonarsource.cloud-native.license-file-generator.gradle.kts

@@ -102,6 +102,7 @@ tasks.register("generateLicenseResources") {
 
     doLast {
         val sonarLicenseFile = project.layout.projectDirectory.asFile.parentFile.resolve("LICENSE.txt")
+        Files.createDirectories(resourceLicenseDir.asFile.toPath())
         Files.copy(
             sonarLicenseFile.toPath(),
             resourceLicenseDir.file("LICENSE.txt").asFile.toPath(),

gradle-modules/src/main/kotlin/org/sonarsource/cloudnative/gradle/AnalyzerLicensingPackagingRenderer.kt

@@ -36,16 +36,20 @@ class AnalyzerLicensingPackagingRenderer(
     private val licenseTitleToResourceFile: Map<String, String> = buildMap {
         put("Apache License, Version 2.0", apacheLicenseFileName)
         put("Apache License Version 2.0", apacheLicenseFileName)
+        put("The Apache License, Version 2.0", apacheLicenseFileName)
         put("Apache 2", apacheLicenseFileName)
         put("Apache-2.0", apacheLicenseFileName)
         put("The Apache Software License, Version 2.0", apacheLicenseFileName)
         put("BSD-3-Clause", "BSD-3.txt")
+        put("BSD", "BSD-2.txt")
         put("GNU LGPL 3", "GNU-LGPL-3.txt")
         put("Go License", "Go.txt")
     }
     private val dependenciesWithUnusableLicenseFileInside: Set<String> = setOf(
         "com.fasterxml.jackson.dataformat.jackson-dataformat-smile",
-        "com.fasterxml.jackson.dataformat.jackson-dataformat-yaml"
+        "com.fasterxml.jackson.dataformat.jackson-dataformat-yaml",
+        "com.fasterxml.woodstox.woodstox-core",
+        "org.codehaus.woodstox.stax2-api"
     )
     private val exceptions: ArrayList<String> = ArrayList()
 
@@ -121,8 +125,7 @@ class AnalyzerLicensingPackagingRenderer(
             return Status.failure("No license found in pom data.")
         }
 
-        copyLicenseFromResources(data, pomLicense.get().name)
-        return Status.success
+        return copyLicenseFromResources(data, pomLicense.get().name)
     }
 
     @Throws(IOException::class)
@@ -147,6 +150,9 @@ class AnalyzerLicensingPackagingRenderer(
         licenseName: String,
     ): Status {
         val licenseResourceFileName = licenseTitleToResourceFile[licenseName]
+        if (licenseResourceFileName == null) {
+            return Status.failure("License file '$licenseName' could not be found.")
+        }
         val resourceAsStream = AnalyzerLicensingPackagingRenderer::class.java.getResourceAsStream("/licenses/$licenseResourceFileName")
             ?: throw IOException("Resource not found for license: $licenseName")
         Files.copy(resourceAsStream, generateLicensePath(data), StandardCopyOption.REPLACE_EXISTING)

gradle-modules/src/main/resources/licenses/BSD-2.txt

@@ -0,0 +1,9 @@
+Copyright <YEAR> <COPYRIGHT HOLDER>
+
+Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:
+
+1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.
+
+2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS “AS IS” AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.