-
Notifications
You must be signed in to change notification settings - Fork 724
Expand file tree
/
Copy pathUndocumentedApi.java
More file actions
356 lines (287 loc) · 7.25 KB
/
UndocumentedApi.java
File metadata and controls
356 lines (287 loc) · 7.25 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
package org.foo.api.mypackage;
/**
* some documentation
*/
public class UndocumentedApi { // Compliant - documented
public String p; // Noncompliant
// ^
private String key; // Compliant - private
public UndocumentedApi() { // Compliant - empty constructor
}
public UndocumentedApi(String key) { // Noncompliant
this.key = key;
}
public void run() { // Noncompliant
}
public interface InnerUndocumentedInterface { // Noncompliant
}
/**
* no violation, because documented
*/
public void run2() {
}
public void setKey(String key) { // Compliant - setter
this.key = key;
}
public String getKey() { // Compliant - getter
return key;
}
@Override
public String toString() { // Compliant - method with override annotation
return key;
}
public static final int FOO = 0; // Compliant - static constant
private static final int BAR = 0; // Compliant - private
int a = 0; // Compliant
}
public enum FooEnum { // Noncompliant {{Document this public enum by adding an explicit description.}}
}
public interface Ainterface { // Noncompliant {{Document this public interface by adding an explicit description.}}
}
public @interface FooAnnotation { // Noncompliant {{Document this public annotation by adding an explicit description.}}
}
public class AClass { // Noncompliant {{Document this public class by adding an explicit description.}}
public int a; // Noncompliant {{Document this public field by adding an explicit description.}}
public A() { // Noncompliant {{Document this public constructor by adding an explicit description.}}
System.out.println();
}
}
/**
* This is a Javadoc comment
*/
public class MyClass<T> implements Runnable { // Noncompliant {{Document the type parameter(s): <T>}}
private int status; // Compliant - not public
/**
* This is a Javadoc comment
*/
public String message; // Compliant - well documented
public MyClass() { // Noncompliant
this.status = 0;
}
public void setStatus(int status) { // Compliant - setter
this.status = status;
}
@Override
public void run() { // Compliant - has @Override annotation
}
protected void doSomething() { // Compliant - not public
}
/**
* Valid descriptions.
* @param value Valid descriptions.
*/
public void doSomething1(int value) { // Compliant
}
/**
* Valid descriptions.
* @return foo Valid descriptions.
*/
public int doSomething2(int value) { // Noncompliant {{Document the parameter(s): value}}
return value;
}
/** Valid descriptions.
* */
public int doSomething3() { // Noncompliant {{Document this method return value.}}
return value;
}
}
/**
*/
interface FooInterface {
/**
* Valid descriptions. */
void foo(); // Compliant
/**
* Valid descriptions. */
int foo1(); // Noncompliant
/**
* Valid descriptions.
* @return Valid descriptions.
*/
int foo2(); // Compliant
/** Valid descriptions.
*/
void foo3(int a); // Noncompliant {{Document the parameter(s): a}}
}
/**
* Valid descriptions.
*/
public class FooClass {
/** Valid descriptions.
*/
public FooClass(int a) { // Noncompliant {{Document the parameter(s): a}}
System.out.println(a);
}
/**
* Valid descriptions.
* @param a Valid descriptions.
*/
public FooClass(int a) { // Compliant
System.out.println(a);
}
}
private class FooPrivate { // Compliant - non pubic
}
class FooPackage { // Compliant - non public
}
/** Valid descriptions..
*/
public class Foo { // Compliant
// Noncompliant@+3
/** Valid descriptions.
*/
public int foo1(int a, int b, int c) { // Noncompliant
return 0;
}
public int foo2(int a, int b, int c) { // Noncompliant {{Document this public method by adding an explicit description.}}
return 0;
}
/**
* Valid descriptions.
* @param <T> foo
*/
public <T> void foo3() { // Compliant - does not return anything
}
public <T> void foo4() { // Noncompliant {{Document this public method by adding an explicit description.}}
}
/**
* Valid descriptions.
* @param <T> foo
*/
public <T> int foo() { // Noncompliant {{Document this method return value.}}
}
/**
* Valid descriptions.
* @param <T> foo Valid descriptions.
* @return Valid descriptions.
*/
public <T> int foo() { // Compliant
}
public void getThisThingDone() { //false negative this is interpreted as a getter.
}
}
/**
* */
public interface bar { // Noncompliant {{Document this public interface by adding an explicit description.}}
/**
* Valid descriptions.
* @param <A> the annotation type
* @param annotationType the <tt>Class</tt> object corresponding to
* the annotation type
* @return the annotation of this declaration having the specified type
*
* @see #getAnnotationMirrors()
*/
<A extends Annotation> A getAnnotation(Class<A> annotationType);
static class A{} // Noncompliant {{Document this public class by adding an explicit description.}}
public int i = 0;
/**
* Valid descriptions.
*/
default void method(){
int j = 1;
}
void getValue(); // Compliant
}
@interface nested{
/**
*
*/
static final class DEFAULT {} // Noncompliant {{Document this public class by adding an explicit description.}}
public int i = 0;
}
/**
* Documented
*/
@Deprecated
public interface deprecatedInterface{
/**
* Doc
*/
@Deprecated
enum Location {
CLASS_TREE;
}
public static final Object constant = new AnonymousClass(){
public void undocumentedMethod(){};
};
}
/**
* Valid descriptions.
*/
public class MyRunner extends Foo {
/**
* {@inheritDoc}
*/
public int foo1(int a, int b, int c) { // Compliant
return 0;
}
private interface Bar {
void method();
}
public void foo // Compliant - Override Foo.foo()
(
)
{
}
/** Valid descriptions.
*/
public interface Foo {
public void foo(); // Noncompliant
}
@Target({METHOD})
@Retention(RUNTIME)
public @interface Transient { // Noncompliant
// ^^^^^^^^^
boolean value() default true; // Noncompliant
}
}
class AnonymousInnerClass {
Comparator<String> doJob(){
return new Comparator<String>() { // anon-inner-class
class Hello { // inner-class
public void doJob() {
}
}
public int compare(String o1, String o2) {
return 0;
}
};
}
}
class PublicConstructorOfNonPublicClass {
public PublicConstructorOfNonPublicClass(int a){
}
}
/**
* Documented
*/
class A {
/**
* Valid descriptions.
*/
public void doSomething() { }
/**
* Valid descriptions.
*/
public static class B extends A {
public void doSomething() { } // Compliant - Override
}
}
@interface MyAnnotation {}
class UsesVisibleForTesting {
@org.fest.util.VisibleForTesting
public void doSomething() {} // Compliant
@com.google.common.annotations.VisibleForTesting
public void doSomethingElse() {} // Compliant
@MyAnnotation
public void doNothing() {} // Noncompliant
}
@Deprecated
public class DeprecatedAPI { //Compliant
public void bar() {} // Noncompliant
@Deprecated
public void foo1() {} // Compliant
@org.foo.qix.Deprecated
public void foo2() {} // Noncompliant
}