SONARJAVA-5665 Improve S4036 message for users (#5229)

Author: loris-s-sonarsource

java-checks-test-sources/default/src/main/files/non-compiling/checks/OSCommandsPath.java

@@ -26,14 +26,14 @@ private void noInitializer() {
   }
 
   private void processBuilderListJava9() {
-    new ProcessBuilder(List.of("make")); // Noncompliant {{Make sure the "PATH" used to find this command includes only what you intend.}}
-    new ProcessBuilder(List.of("m../ake")); // Noncompliant {{Make sure the "PATH" used to find this command includes only what you intend.}}
-    new ProcessBuilder(List.of("mak./e")); // Noncompliant {{Make sure the "PATH" used to find this command includes only what you intend.}}
-    new ProcessBuilder(List.of("bin~/make")); // Noncompliant {{Make sure the "PATH" used to find this command includes only what you intend.}}
-    new ProcessBuilder(List.of("7:\\\\make")); // Noncompliant {{Make sure the "PATH" used to find this command includes only what you intend.}}
-    new ProcessBuilder(List.of("m..\\ake")); // Noncompliant {{Make sure the "PATH" used to find this command includes only what you intend.}}
-    new ProcessBuilder(List.of("ma.\\ke")); // Noncompliant {{Make sure the "PATH" used to find this command includes only what you intend.}}
-    new ProcessBuilder(List.of("SERVER\\make")); // Noncompliant {{Make sure the "PATH" used to find this command includes only what you intend.}}
+    new ProcessBuilder(List.of("make")); // Noncompliant {{Make sure the "PATH" variable only contains fixed, unwriteable directories.}}
+    new ProcessBuilder(List.of("m../ake")); // Noncompliant {{Make sure the "PATH" variable only contains fixed, unwriteable directories.}}
+    new ProcessBuilder(List.of("mak./e")); // Noncompliant {{Make sure the "PATH" variable only contains fixed, unwriteable directories.}}
+    new ProcessBuilder(List.of("bin~/make")); // Noncompliant {{Make sure the "PATH" variable only contains fixed, unwriteable directories.}}
+    new ProcessBuilder(List.of("7:\\\\make")); // Noncompliant {{Make sure the "PATH" variable only contains fixed, unwriteable directories.}}
+    new ProcessBuilder(List.of("m..\\ake")); // Noncompliant {{Make sure the "PATH" variable only contains fixed, unwriteable directories.}}
+    new ProcessBuilder(List.of("ma.\\ke")); // Noncompliant {{Make sure the "PATH" variable only contains fixed, unwriteable directories.}}
+    new ProcessBuilder(List.of("SERVER\\make")); // Noncompliant {{Make sure the "PATH" variable only contains fixed, unwriteable directories.}}
     new ProcessBuilder(List.of("/usr/bin/make"));
     new ProcessBuilder(List.of("../make"));
     new ProcessBuilder(List.of("./make"));
@@ -47,14 +47,14 @@ private void processBuilderListJava9() {
   private void commandJava9() {
     ProcessBuilder builder = new ProcessBuilder();
 
-    builder.command(List.of("make")); // Noncompliant {{Make sure the "PATH" used to find this command includes only what you intend.}}
-    builder.command(List.of("m../ake")); // Noncompliant {{Make sure the "PATH" used to find this command includes only what you intend.}}
-    builder.command(List.of("mak./e")); // Noncompliant {{Make sure the "PATH" used to find this command includes only what you intend.}}
-    builder.command(List.of("bin~/make")); // Noncompliant {{Make sure the "PATH" used to find this command includes only what you intend.}}
-    builder.command(List.of("7:\\\\make")); // Noncompliant {{Make sure the "PATH" used to find this command includes only what you intend.}}
-    builder.command(List.of("m..\\ake")); // Noncompliant {{Make sure the "PATH" used to find this command includes only what you intend.}}
-    builder.command(List.of("ma.\\ke")); // Noncompliant {{Make sure the "PATH" used to find this command includes only what you intend.}}
-    builder.command(List.of("SERVER\\make")); // Noncompliant {{Make sure the "PATH" used to find this command includes only what you intend.}}
+    builder.command(List.of("make")); // Noncompliant {{Make sure the "PATH" variable only contains fixed, unwriteable directories.}}
+    builder.command(List.of("m../ake")); // Noncompliant {{Make sure the "PATH" variable only contains fixed, unwriteable directories.}}
+    builder.command(List.of("mak./e")); // Noncompliant {{Make sure the "PATH" variable only contains fixed, unwriteable directories.}}
+    builder.command(List.of("bin~/make")); // Noncompliant {{Make sure the "PATH" variable only contains fixed, unwriteable directories.}}
+    builder.command(List.of("7:\\\\make")); // Noncompliant {{Make sure the "PATH" variable only contains fixed, unwriteable directories.}}
+    builder.command(List.of("m..\\ake")); // Noncompliant {{Make sure the "PATH" variable only contains fixed, unwriteable directories.}}
+    builder.command(List.of("ma.\\ke")); // Noncompliant {{Make sure the "PATH" variable only contains fixed, unwriteable directories.}}
+    builder.command(List.of("SERVER\\make")); // Noncompliant {{Make sure the "PATH" variable only contains fixed, unwriteable directories.}}
     builder.command(List.of("/usr/bin/make"));
     builder.command(List.of("../make"));
     builder.command(List.of("./make"));