Skip to content

Commit 455b07c

Browse files
SONARJAVA-5544 Deprecate rule S6300
1 parent 4ad20ab commit 455b07c

6 files changed

Lines changed: 4 additions & 19 deletions

File tree

its/autoscan/src/test/java/org/sonar/java/it/AutoScanTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ public void javaCheckTestSources() throws Exception {
196196
softly.assertThat(newDiffs).containsExactlyInAnyOrderElementsOf(knownDiffs.values());
197197
softly.assertThat(newTotal).isEqualTo(knownTotal);
198198
softly.assertThat(rulesCausingFPs).hasSize(9);
199-
softly.assertThat(rulesNotReporting).hasSize(11);
199+
softly.assertThat(rulesNotReporting).hasSize(10);
200200

201201
/**
202202
* 4. Check total number of differences (FPs + FNs)

its/autoscan/src/test/resources/autoscan/autoscan-diff-by-rules.json

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2741,12 +2741,6 @@
27412741
"falseNegatives": 0,
27422742
"falsePositives": 0
27432743
},
2744-
{
2745-
"ruleKey": "S6300",
2746-
"hasTruePositives": false,
2747-
"falseNegatives": 0,
2748-
"falsePositives": 0
2749-
},
27502744
{
27512745
"ruleKey": "S6301",
27522746
"hasTruePositives": true,

its/autoscan/src/test/resources/autoscan/diffs/diff_S6300.json

Lines changed: 0 additions & 6 deletions
This file was deleted.

sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S6300.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
<p>This rule is deprecated, and will eventually be removed.</p>
12
<p>Storing files locally is a common task for mobile applications. Files that are stored unencrypted can be read out and modified by an attacker with
23
physical access to the device. Access to sensitive data can be harmful for the user of the application, for example when the device gets stolen.</p>
34
<h2>Ask Yourself Whether</h2>

sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S6300.json

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,12 @@
77
},
88
"attribute": "TRUSTWORTHY"
99
},
10-
"status": "ready",
10+
"status": "deprecated",
1111
"remediation": {
1212
"func": "Constant\/Issue",
1313
"constantCost": "10min"
1414
},
15-
"tags": [
16-
"cwe",
17-
"android"
18-
],
15+
"tags": [],
1916
"defaultSeverity": "Major",
2017
"ruleSpecification": "RSPEC-6300",
2118
"sqKey": "S6300",

sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/Sonar_way_profile.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,6 @@
438438
"S6263",
439439
"S6288",
440440
"S6293",
441-
"S6300",
442441
"S6301",
443442
"S6326",
444443
"S6331",

0 commit comments

Comments
 (0)