SONARJAVA-5534 Remove SE engine and unused duplicated check test sources (#5176)

Co-authored-by: Leonardo Pilastri <leonardo.pilastri@sonarsource.com>

Author: alban-auzeill

.cirrus.yml

@@ -95,7 +95,7 @@ test_analyze_task:
     - *log_develocity_url_script
     - source cirrus-env BUILD
     # ignore duplications in the SE engine plugin, as it will be moved away from sonar-java at some point
-    - PULL_REQUEST_SHA=$GIT_SHA1 regular_mvn_build_deploy_analyze -P-deploy-sonarsource,-release,-sign -Dmaven.deploy.skip=true -Dsonar.analysisCache.enabled=true -Dsonar.cpd.exclusions=java-symbolic-execution/** -Dsonar.sca.exclusions="**/test/files/**, **/test/resources/**, its/plugin/projects/**, java-checks-test-sources/**, its/sources/**,"
+    - PULL_REQUEST_SHA=$GIT_SHA1 regular_mvn_build_deploy_analyze -P-deploy-sonarsource,-release,-sign -Dmaven.deploy.skip=true -Dsonar.analysisCache.enabled=true -Dsonar.sca.exclusions="**/test/files/**, **/test/resources/**, its/plugin/projects/**, java-checks-test-sources/**, its/sources/**,"
     - cd docs/java-custom-rules-example
     - mvn clean package -f pom_SQ_10_6_LATEST.xml --batch-mode
     - cd "${CIRRUS_WORKING_DIR}"

.github/workflows/UpdateRuleMetadata.yml

@@ -42,8 +42,6 @@ jobs:
         run: |
           java -jar "/tmp/rule-api.jar" update
           sed --in-place='' -e 's/rule:java:S3649/rule:javasecurity:S3649/g' 'sonar-java-plugin/src/main/resources/org/sonar/l10n/java/rules/java/S2077.html'
-          cd java-symbolic-execution
-          java -jar "/tmp/rule-api.jar" update
 
       - name: Create PR
         env:

check-list/src/main/java/org/sonar/java/CheckListGenerator.java

@@ -175,7 +175,6 @@ public final class ${className} {
           .collect(Collectors.toList());
 
           private static final Set<Class<? extends JavaCheck>> JAVA_CHECKS_NOT_WORKING_FOR_AUTOSCAN = Set.of(
-            // Symbolic executions rules are not in this list because they are dynamically excluded
             // Rules relying on correct setup of jdk.home
             CallToDeprecatedCodeMarkedForRemovalCheck.class,
             CallToDeprecatedMethodCheck.class,

its/autoscan/pom.xml

@@ -81,12 +81,6 @@
       <version>${project.version}</version>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>org.sonarsource.java</groupId>
-      <artifactId>sonar-java-symbolic-execution-plugin</artifactId>
-      <version>${project.version}</version>
-      <scope>test</scope>
-    </dependency>
   </dependencies>
 
   <profiles>

its/autoscan/src/test/java/org/sonar/java/it/AutoScanTest.java

@@ -66,7 +66,6 @@ public class AutoScanTest {
     .useDefaultAdminCredentialsForBuilds(true)
     .setSonarVersion(System.getProperty("sonar.runtimeVersion", "LATEST_RELEASE"))
     .addPlugin(FileLocation.of(TestClasspathUtils.findModuleJarPath("../../sonar-java-plugin").toFile()))
-    .addPlugin(FileLocation.of(TestClasspathUtils.findModuleJarPath("../../java-symbolic-execution/java-symbolic-execution-plugin").toFile()))
     .addPlugin(MavenLocation.of("org.sonarsource.sonar-lits-plugin", "sonar-lits-plugin", "0.11.0.2659"))
     .build();
 
@@ -196,7 +195,7 @@ public void javaCheckTestSources() throws Exception {
     softly.assertThat(newDiffs).containsExactlyInAnyOrderElementsOf(knownDiffs.values());
     softly.assertThat(newTotal).isEqualTo(knownTotal);
     softly.assertThat(rulesCausingFPs).hasSize(9);
-    softly.assertThat(rulesNotReporting).hasSize(10);
+    softly.assertThat(rulesNotReporting).hasSize(12);
 
     /**
      * 4. Check total number of differences (FPs + FNs)

its/autoscan/src/test/resources/autoscan/autoscan-diff-by-rules.json

@@ -803,12 +803,6 @@
     "falseNegatives": 0,
     "falsePositives": 0
   },
-  {
-    "ruleKey": "S2095",
-    "hasTruePositives": true,
-    "falseNegatives": 67,
-    "falsePositives": 0
-  },
   {
     "ruleKey": "S2097",
     "hasTruePositives": true,
@@ -1055,12 +1049,6 @@
     "falseNegatives": 2,
     "falsePositives": 0
   },
-  {
-    "ruleKey": "S2189",
-    "hasTruePositives": true,
-    "falseNegatives": 0,
-    "falsePositives": 0
-  },
   {
     "ruleKey": "S2200",
     "hasTruePositives": true,
@@ -1085,12 +1073,6 @@
     "falseNegatives": 17,
     "falsePositives": 0
   },
-  {
-    "ruleKey": "S2222",
-    "hasTruePositives": true,
-    "falseNegatives": 0,
-    "falsePositives": 0
-  },
   {
     "ruleKey": "S2225",
     "hasTruePositives": true,
@@ -1169,12 +1151,6 @@
     "falseNegatives": 0,
     "falsePositives": 0
   },
-  {
-    "ruleKey": "S2259",
-    "hasTruePositives": true,
-    "falseNegatives": 4,
-    "falsePositives": 0
-  },
   {
     "ruleKey": "S2272",
     "hasTruePositives": true,
@@ -1295,18 +1271,6 @@
     "falseNegatives": 0,
     "falsePositives": 0
   },
-  {
-    "ruleKey": "S2583",
-    "hasTruePositives": true,
-    "falseNegatives": 20,
-    "falsePositives": 0
-  },
-  {
-    "ruleKey": "S2589",
-    "hasTruePositives": true,
-    "falseNegatives": 6,
-    "falsePositives": 0
-  },
   {
     "ruleKey": "S2612",
     "hasTruePositives": true,
@@ -1319,12 +1283,6 @@
     "falseNegatives": 60,
     "falsePositives": 0
   },
-  {
-    "ruleKey": "S2637",
-    "hasTruePositives": true,
-    "falseNegatives": 87,
-    "falsePositives": 0
-  },
   {
     "ruleKey": "S2638",
     "hasTruePositives": true,
@@ -1373,12 +1331,6 @@
     "falseNegatives": 0,
     "falsePositives": 0
   },
-  {
-    "ruleKey": "S2689",
-    "hasTruePositives": true,
-    "falseNegatives": 0,
-    "falsePositives": 0
-  },
   {
     "ruleKey": "S2692",
     "hasTruePositives": true,
@@ -1415,12 +1367,6 @@
     "falseNegatives": 0,
     "falsePositives": 0
   },
-  {
-    "ruleKey": "S2755",
-    "hasTruePositives": false,
-    "falseNegatives": 100,
-    "falsePositives": 0
-  },
   {
     "ruleKey": "S2757",
     "hasTruePositives": true,
@@ -1559,12 +1505,6 @@
     "falseNegatives": 0,
     "falsePositives": 0
   },
-  {
-    "ruleKey": "S3065",
-    "hasTruePositives": true,
-    "falseNegatives": 0,
-    "falsePositives": 0
-  },
   {
     "ruleKey": "S3066",
     "hasTruePositives": true,
@@ -1661,18 +1601,6 @@
     "falseNegatives": 150,
     "falsePositives": 0
   },
-  {
-    "ruleKey": "S3516",
-    "hasTruePositives": true,
-    "falseNegatives": 8,
-    "falsePositives": 0
-  },
-  {
-    "ruleKey": "S3518",
-    "hasTruePositives": true,
-    "falseNegatives": 7,
-    "falsePositives": 0
-  },
   {
     "ruleKey": "S3551",
     "hasTruePositives": true,
@@ -1703,12 +1631,6 @@
     "falseNegatives": 0,
     "falsePositives": 0
   },
-  {
-    "ruleKey": "S3655",
-    "hasTruePositives": true,
-    "falseNegatives": 8,
-    "falsePositives": 0
-  },
   {
     "ruleKey": "S3740",
     "hasTruePositives": true,
@@ -1739,12 +1661,6 @@
     "falseNegatives": 0,
     "falsePositives": 0
   },
-  {
-    "ruleKey": "S3824",
-    "hasTruePositives": true,
-    "falseNegatives": 0,
-    "falsePositives": 0
-  },
   {
     "ruleKey": "S3864",
     "hasTruePositives": true,
@@ -1763,18 +1679,6 @@
     "falseNegatives": 0,
     "falsePositives": 0
   },
-  {
-    "ruleKey": "S3958",
-    "hasTruePositives": true,
-    "falseNegatives": 4,
-    "falsePositives": 0
-  },
-  {
-    "ruleKey": "S3959",
-    "hasTruePositives": true,
-    "falseNegatives": 0,
-    "falsePositives": 0
-  },
   {
     "ruleKey": "S3972",
     "hasTruePositives": true,
@@ -1859,12 +1763,6 @@
     "falseNegatives": 3,
     "falsePositives": 7
   },
-  {
-    "ruleKey": "S4165",
-    "hasTruePositives": true,
-    "falseNegatives": 1,
-    "falsePositives": 0
-  },
   {
     "ruleKey": "S4201",
     "hasTruePositives": true,
@@ -1943,12 +1841,6 @@
     "falseNegatives": 0,
     "falsePositives": 0
   },
-  {
-    "ruleKey": "S4449",
-    "hasTruePositives": false,
-    "falseNegatives": 27,
-    "falsePositives": 0
-  },
   {
     "ruleKey": "S4454",
     "hasTruePositives": true,
@@ -2783,24 +2675,6 @@
     "falseNegatives": 0,
     "falsePositives": 0
   },
-  {
-    "ruleKey": "S6373",
-    "hasTruePositives": false,
-    "falseNegatives": 15,
-    "falsePositives": 0
-  },
-  {
-    "ruleKey": "S6376",
-    "hasTruePositives": false,
-    "falseNegatives": 15,
-    "falsePositives": 0
-  },
-  {
-    "ruleKey": "S6377",
-    "hasTruePositives": false,
-    "falseNegatives": 6,
-    "falsePositives": 0
-  },
   {
     "ruleKey": "S6395",
     "hasTruePositives": true,

its/autoscan/src/test/resources/autoscan/diffs/diff_S1128.json

@@ -1,6 +1,6 @@
 {
   "ruleKey": "S1128",
   "hasTruePositives": true,
-  "falseNegatives": 33,
+  "falseNegatives": 32,
   "falsePositives": 0
-}
+}

its/autoscan/src/test/resources/autoscan/diffs/diff_S1130.json

@@ -1,6 +1,6 @@
 {
   "ruleKey": "S1130",
   "hasTruePositives": true,
-  "falseNegatives": 25,
+  "falseNegatives": 11,
   "falsePositives": 0
-}
+}

its/autoscan/src/test/resources/autoscan/diffs/diff_S1172.json

@@ -1,6 +1,6 @@
 {
   "ruleKey": "S1172",
   "hasTruePositives": true,
-  "falseNegatives": 25,
+  "falseNegatives": 23,
   "falsePositives": 0
-}
+}

its/autoscan/src/test/resources/autoscan/diffs/diff_S1874.json

@@ -1,6 +1,6 @@
 {
   "ruleKey": "S1874",
   "hasTruePositives": true,
-  "falseNegatives": 258,
+  "falseNegatives": 249,
   "falsePositives": 0
-}
+}