SONARJAVA-4473 fix FP in S2384 when mutable value is stored by private methods or constructors (#5112)

To reduce false positives, we only consider non-private methods.

Author: romainbrenguier

its/ruling/src/test/resources/commons-beanutils/java-S2384.json

@@ -25,8 +25,5 @@
 "commons-beanutils:commons-beanutils:src/main/java/org/apache/commons/beanutils2/converters/DateTimeConverter.java": [
 186,
 197
-],
-"commons-beanutils:commons-beanutils:src/main/java/org/apache/commons/beanutils2/locale/LocaleConvertUtilsBean.java": [
-505
 ]
 }

its/ruling/src/test/resources/eclipse-jetty-similar-to-main/java-S2384.json

@@ -21,19 +21,14 @@
 118
 ],
 "org.eclipse.jetty:jetty-project:jetty-io/src/main/java/org/eclipse/jetty/io/ManagedSelector.java": [
-742,
-955
+742
 ],
 "org.eclipse.jetty:jetty-project:jetty-io/src/main/java/org/eclipse/jetty/io/NegotiatingClientConnection.java": [
 45
 ],
 "org.eclipse.jetty:jetty-project:jetty-io/src/main/java/org/eclipse/jetty/io/WriteFlusher.java": [
-217,
 223
 ],
-"org.eclipse.jetty:jetty-project:jetty-io/src/main/java/org/eclipse/jetty/io/ssl/SslClientConnectionFactory.java": [
-148
-],
 "org.eclipse.jetty:jetty-project:jetty-jmx/src/main/java/org/eclipse/jetty/jmx/MetaData.java": [
 73
 ],
@@ -89,9 +84,7 @@
 196
 ],
 "org.eclipse.jetty:jetty-project:jetty-server/src/main/java/org/eclipse/jetty/server/SecureRequestCustomizer.java": [
-354,
-430,
-441
+354
 ],
 "org.eclipse.jetty:jetty-project:jetty-server/src/main/java/org/eclipse/jetty/server/handler/ContextHandler.java": [
 343,

its/ruling/src/test/resources/eclipse-jetty/java-S2384.json

@@ -21,19 +21,14 @@
 118
 ],
 "org.eclipse.jetty:jetty-project:jetty-io/src/main/java/org/eclipse/jetty/io/ManagedSelector.java": [
-742,
-955
+742
 ],
 "org.eclipse.jetty:jetty-project:jetty-io/src/main/java/org/eclipse/jetty/io/NegotiatingClientConnection.java": [
 45
 ],
 "org.eclipse.jetty:jetty-project:jetty-io/src/main/java/org/eclipse/jetty/io/WriteFlusher.java": [
-217,
 223
 ],
-"org.eclipse.jetty:jetty-project:jetty-io/src/main/java/org/eclipse/jetty/io/ssl/SslClientConnectionFactory.java": [
-148
-],
 "org.eclipse.jetty:jetty-project:jetty-jmx/src/main/java/org/eclipse/jetty/jmx/MetaData.java": [
 73
 ],
@@ -89,9 +84,7 @@
 196
 ],
 "org.eclipse.jetty:jetty-project:jetty-server/src/main/java/org/eclipse/jetty/server/SecureRequestCustomizer.java": [
-354,
-430,
-441
+354
 ],
 "org.eclipse.jetty:jetty-project:jetty-server/src/main/java/org/eclipse/jetty/server/handler/ContextHandler.java": [
 343,
@@ -135,9 +128,6 @@
 "org.eclipse.jetty:jetty-project:jetty-util/src/main/java/org/eclipse/jetty/util/PathWatcher.java": [
 757
 ],
-"org.eclipse.jetty:jetty-project:jetty-util/src/main/java/org/eclipse/jetty/util/SearchPattern.java": [
-72
-],
 "org.eclipse.jetty:jetty-project:jetty-util/src/main/java/org/eclipse/jetty/util/component/AbstractLifeCycle.java": [
 194
 ],
@@ -172,9 +162,7 @@
 ],
 "org.eclipse.jetty:jetty-project:jetty-xml/src/main/java/org/eclipse/jetty/xml/XmlConfiguration.java": [
 285,
-296,
-1611,
-1612
+296
 ],
 "org.eclipse.jetty:jetty-project:jetty-xml/src/main/java/org/eclipse/jetty/xml/XmlParser.java": [
 560

its/ruling/src/test/resources/guava/java-S2384.json

@@ -3,18 +3,10 @@
 1314,
 1315
 ],
-"com.google.guava:guava:src/com/google/common/base/Predicates.java": [
-367,
-409
-],
-"com.google.guava:guava:src/com/google/common/base/SmallCharMatcher.java": [
-40
-],
 "com.google.guava:guava:src/com/google/common/cache/LocalCache.java": [
 4498
 ],
 "com.google.guava:guava:src/com/google/common/collect/AbstractBiMap.java": [
-63,
 69,
 96
 ],
@@ -39,12 +31,6 @@
 "com.google.guava:guava:src/com/google/common/collect/HashBiMap.java": [
 684
 ],
-"com.google.guava:guava:src/com/google/common/collect/ImmutableEnumMap.java": [
-52
-],
-"com.google.guava:guava:src/com/google/common/collect/ImmutableEnumSet.java": [
-57
-],
 "com.google.guava:guava:src/com/google/common/collect/ImmutableMapEntrySet.java": [
 42
 ],
@@ -60,7 +46,6 @@
 767,
 1316,
 1320,
-3118,
 3133,
 3174,
 3179,
@@ -69,26 +54,16 @@
 "com.google.guava:guava:src/com/google/common/collect/Multisets.java": [
 1041
 ],
-"com.google.guava:guava:src/com/google/common/collect/RegularImmutableBiMap.java": [
-112,
-113,
-114
-],
 "com.google.guava:guava:src/com/google/common/collect/RegularImmutableList.java": [
 40
 ],
-"com.google.guava:guava:src/com/google/common/collect/RegularImmutableMap.java": [
-91,
-92
-],
 "com.google.guava:guava:src/com/google/common/collect/RegularImmutableSet.java": [
 44
 ],
 "com.google.guava:guava:src/com/google/common/collect/RegularImmutableSortedMultiset.java": [
 54
 ],
 "com.google.guava:guava:src/com/google/common/collect/Sets.java": [
-1194,
 1199,
 1602,
 1607,
@@ -99,21 +74,16 @@
 58
 ],
 "com.google.guava:guava:src/com/google/common/collect/Synchronized.java": [
-1116,
 1128,
 1146
 ],
 "com.google.guava:guava:src/com/google/common/collect/TreeRangeSet.java": [
-268,
-274,
-433
+268
 ],
 "com.google.guava:guava:src/com/google/common/collect/WellBehavedMap.java": [
-43,
 57
 ],
 "com.google.guava:guava:src/com/google/common/escape/ArrayBasedEscaperMap.java": [
-64,
 69
 ],
 "com.google.guava:guava:src/com/google/common/escape/CharEscaperBuilder.java": [

its/ruling/src/test/resources/sonar-server/java-S2384.json

@@ -16,17 +16,9 @@
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/batch/BatchWs.java": [
 33
 ],
-"org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/batch/ProjectDataLoader.java": [
-225,
-226
-],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/ce/ws/CeWs.java": [
 31
 ],
-"org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/ce/ws/TaskFormatter.java": [
-152,
-153
-],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/component/ComponentService.java": [
 43
 ],
@@ -45,22 +37,13 @@
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/component/ws/FilterParser.java": [
 142
 ],
-"org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/component/ws/SearchProjectsAction.java": [
-411,
-413,
-414,
-460,
-461,
-464
-],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/computation/task/projectanalysis/api/measurecomputer/MeasureComputerContextImpl.java": [
 183
 ],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/computation/task/projectanalysis/api/posttask/ConditionToCondition.java": [
 41
 ],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/computation/task/projectanalysis/api/posttask/ScannerContextImpl.java": [
-35,
 40
 ],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/computation/task/projectanalysis/component/DisabledComponentsHolderImpl.java": [
@@ -107,8 +90,7 @@
 102
 ],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/computation/task/projectanalysis/step/LoadMeasureComputersStep.java": [
-58,
-144
+58
 ],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/computation/task/projectanalysis/step/PersistComponentsStep.java": [
 170
@@ -180,16 +162,11 @@
 126
 ],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/exceptions/BadRequestException.java": [
-38,
 52
 ],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/favorite/ws/FavoritesWs.java": [
 28
 ],
-"org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/favorite/ws/SearchAction.java": [
-121,
-122
-],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/issue/Action.java": [
 62
 ],
@@ -235,7 +212,6 @@
 ],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/issue/Result.java": [
 70,
-95,
 119
 ],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/issue/index/IssueIteratorForSingleChunk.java": [
@@ -300,9 +276,6 @@
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/metric/ws/MetricsWs.java": [
 31
 ],
-"org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/metric/ws/SearchAction.java": [
-98
-],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/notification/DefaultNotificationManager.java": [
 59
 ],
@@ -320,7 +293,6 @@
 28
 ],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/permission/ApplyPermissionTemplateQuery.java": [
-34,
 47
 ],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/permission/index/PermissionIndexer.java": [
@@ -375,24 +347,15 @@
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/project/Visibility.java": [
 68
 ],
-"org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/project/ws/GhostsAction.java": [
-149
-],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/project/ws/ProjectsWs.java": [
 32
 ],
-"org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/project/ws/ProvisionedAction.java": [
-150
-],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/project/ws/SearchMyProjectsData.java": [
 106,
 111,
 116,
 121
 ],
-"org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/project/ws/SearchMyProjectsDataLoader.java": [
-97
-],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/projectanalysis/ws/ProjectAnalysesWs.java": [
 29
 ],
@@ -414,7 +377,6 @@
 247
 ],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/qualitygate/QgateProjectFinder.java": [
-97,
 102
 ],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/qualitygate/ws/QualityGatesWs.java": [
@@ -486,9 +448,6 @@
 78,
 173
 ],
-"org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/rule/RuleUpdater.java": [
-275
-],
 "org.sonarsource.sonarqube:sonar-server:src/main/java/org/sonar/server/rule/index/RuleQuery.java": [
 103,
 107,