SONARJAVA-5494 Add quickfixes for S7477 (#5225)

Author: romainbrenguier

java-checks-test-sources/default/src/main/java/checks/ClassNameInClassTransformCheckSample.java

@@ -20,19 +20,21 @@ public class ClassNameInClassTransformCheckSample {
   public byte[] transformClassFileNonCompliantDesc(Path path) throws IOException {
     ClassFile classFile = ClassFile.of();
     ClassModel classModel = classFile.parse(path);
-    return classFile.transformClass(classModel,
-      classModel.thisClass(), // Noncompliant {{Use `transformClass` overload without the class name.}}
-//    ^^^^^^^^^^^^^^^^^^^^^^
-      classTransform);
+    return classFile.transformClass(classModel, classModel.thisClass(), classTransform); // Noncompliant {{Use `transformClass` overload without the class name.}} [[quickfixes=qf1]]
+//                                              ^^^^^^^^^^^^^^^^^^^^^^
+// fix@qf1 {{Remove second argument.}}
+// edit@qf1 [[sc=47;ec=73]] {{, }}
+
   }
 
   public byte[] transformClassFileNonCompliant(Path path) throws IOException {
     ClassFile classFile = ClassFile.of();
     ClassModel classModel = classFile.parse(path);
-    return classFile.transformClass(classModel,
-      classModel.thisClass().asSymbol(), // Noncompliant {{Use `transformClass` overload without the class name.}}
-//    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-      classTransform);
+    return classFile.transformClass(classModel, classModel.thisClass().asSymbol(), classTransform); // Noncompliant {{Use `transformClass` overload without the class name.}} [[quickfixes=qf2]]
+//                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+// fix@qf2 {{Remove second argument.}}
+// edit@qf2 [[sc=47;ec=84]] {{, }}
+
   }
 
   public byte[] transformClassFileNonCompliantInternalName(Path path) throws IOException {

java-checks/src/main/java/org/sonar/java/checks/ClassNameInClassTransformCheck.java

@@ -20,8 +20,12 @@
 import java.util.function.Predicate;
 
 import org.sonar.check.Rule;
+import org.sonar.java.checks.helpers.QuickFixHelper;
+import org.sonar.java.reporting.JavaQuickFix;
+import org.sonar.java.reporting.JavaTextEdit;
 import org.sonar.plugins.java.api.IssuableSubscriptionVisitor;
 import org.sonar.plugins.java.api.semantic.MethodMatchers;
+import org.sonar.plugins.java.api.tree.Arguments;
 import org.sonar.plugins.java.api.tree.ExpressionTree;
 import org.sonar.plugins.java.api.tree.IdentifierTree;
 import org.sonar.plugins.java.api.tree.MemberSelectExpressionTree;
@@ -35,6 +39,7 @@ public class ClassNameInClassTransformCheck extends IssuableSubscriptionVisitor
   private static final String CLASS_ENTRY_CLASSNAME = "java.lang.classfile.constantpool.ClassEntry";
   private static final String CLASS_MODEL_CLASSNAME = "java.lang.classfile.ClassModel";
   private static final String CLASS_DESC_CLASSNAME = "java.lang.constant.ClassDesc";
+  private static final String ISSUE_MESSAGE = "Use `transformClass` overload without the class name.";
 
   MethodMatchers classTransformMatcher = MethodMatchers.create()
     .ofTypes("java.lang.classfile.ClassFile")
@@ -166,11 +171,25 @@ public void visitNode(Tree tree) {
       ExpressionTree classDesc = mit.arguments().get(1);
       if (classModel instanceof IdentifierTree classModelId &&
         (isThisClassOf(classModelId).test(classDesc) || isDescriptorOf(classModelId).test(classDesc))) {
-        context.reportIssue(this, classDesc, "Use `transformClass` overload without the class name.");
+
+        QuickFixHelper.newIssue(context)
+          .forRule(this)
+          .onTree(classDesc)
+          .withMessage(ISSUE_MESSAGE)
+          .withQuickFix(() -> computeQuickFix(mit.arguments()))
+          .report();
       }
     }
   }
 
+  private static JavaQuickFix computeQuickFix(Arguments arguments) {
+    return JavaQuickFix
+      .newQuickFix("Remove second argument.")
+      .addTextEdit(JavaTextEdit.replaceBetweenTree(
+              arguments.get(0), false, arguments.get(2), false, ", "))
+      .build();
+  }
+
   /** The expression may be of the form `model.thisClass().asInternalName()` or `model.thisClass().name().stringValue(). */
   private Predicate<ExpressionTree> isInternalNameOf(IdentifierTree classModel) {
     return expression -> check(expression).calls(internalNameMatcher).onExpression().matches(isThisClassOf(classModel))