SCANNERAPI-185 - Fixed code smell

mickael-caro-sonarsource · mickael-caro-sonarsource · commit 13cbd57634f2 · 2019-12-16T13:20:39.000+01:00
diff --git a/api/src/main/java/org/sonarsource/scanner/api/internal/ServerConnection.java b/api/src/main/java/org/sonarsource/scanner/api/internal/ServerConnection.java
@@ -24,6 +24,7 @@
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.StandardCopyOption;
+import java.util.Locale;
 import java.util.Map;
 import okhttp3.OkHttpClient;
 import okhttp3.Request;
@@ -116,7 +117,7 @@ private ResponseBody callUrl(String url) throws IOException {
       }
       return response.body();
     } catch (Exception e) {
-      logger.error(format("%s server [%s] can not be reached", url.toLowerCase().contains("sonarcloud") ? "SonarCloud" : "SonarQube", baseUrlWithoutTrailingSlash));
+      logger.error(format("%s server [%s] can not be reached", url.toLowerCase(Locale.getDefault()).contains("sonarcloud") ? "SonarCloud" : "SonarQube", baseUrlWithoutTrailingSlash));
       throw e;
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@`
`24`	`24`	`import java.nio.file.Files;`
`25`	`25`	`import java.nio.file.Path;`
`26`	`26`	`import java.nio.file.StandardCopyOption;`
	`27`	`+import java.util.Locale;`
`27`	`28`	`import java.util.Map;`
`28`	`29`	`import okhttp3.OkHttpClient;`
`29`	`30`	`import okhttp3.Request;`
`@@ -116,7 +117,7 @@ private ResponseBody callUrl(String url) throws IOException {`
`116`	`117`	`}`
`117`	`118`	`return response.body();`
`118`	`119`	`} catch (Exception e) {`
`119`		`- logger.error(format("%s server [%s] can not be reached", url.toLowerCase().contains("sonarcloud") ? "SonarCloud" : "SonarQube", baseUrlWithoutTrailingSlash));`
	`120`	`+ logger.error(format("%s server [%s] can not be reached", url.toLowerCase(Locale.getDefault()).contains("sonarcloud") ? "SonarCloud" : "SonarQube", baseUrlWithoutTrailingSlash));`
`120`	`121`	`throw e;`
`121`	`122`	`}`
`122`	`123`	`}`