Fix quality flaws

Author: henryju

lib/src/main/java/org/sonarsource/scanner/lib/internal/IsolatedLauncherFactory.java

@@ -57,7 +57,7 @@ private IsolatedClassloader createClassLoader(List<Path> jarFiles, ClassloadRule
   }
 
   public IsolatedLauncherAndClassloader createLauncher(ClassloadRules rules, ServerConnection serverConnection, FileCache fileCache) {
-    LegacyScannerEngineDownloader legacyScannerEngineDownloader = new JarDownloaderFactory(serverConnection, logger, fileCache).create();
+    LegacyScannerEngineDownloader legacyScannerEngineDownloader = new LegacyScannerEngineDownloaderFactory(serverConnection, logger, fileCache).create();
     return createLauncher(legacyScannerEngineDownloader, rules);
   }
 

…r/lib/internal/JarDownloaderFactory.java …egacyScannerEngineDownloaderFactory.javalib/src/main/java/org/sonarsource/scanner/lib/internal/JarDownloaderFactory.java renamed to lib/src/main/java/org/sonarsource/scanner/lib/internal/LegacyScannerEngineDownloaderFactory.java lib/src/main/java/org/sonarsource/scanner/lib/internal/JarDownloaderFactory.java renamed to lib/src/main/java/org/sonarsource/scanner/lib/internal/LegacyScannerEngineDownloaderFactory.java

@@ -23,12 +23,12 @@
 import org.sonarsource.scanner.lib.internal.cache.Logger;
 import org.sonarsource.scanner.lib.internal.http.ServerConnection;
 
-class JarDownloaderFactory {
+class LegacyScannerEngineDownloaderFactory {
   private final ServerConnection serverConnection;
   private final Logger logger;
   private final FileCache fileCache;
 
-  JarDownloaderFactory(ServerConnection conn, Logger logger, FileCache fileCache) {
+  LegacyScannerEngineDownloaderFactory(ServerConnection conn, Logger logger, FileCache fileCache) {
     this.serverConnection = conn;
     this.logger = logger;
     this.fileCache = fileCache;

lib/src/main/java/org/sonarsource/scanner/lib/internal/util/package-info.java

@@ -0,0 +1,23 @@
+/*
+ * SonarScanner Java Library
+ * Copyright (C) 2011-2024 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 3 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+ */
+@ParametersAreNonnullByDefault
+package org.sonarsource.scanner.lib.internal.util;
+
+import javax.annotation.ParametersAreNonnullByDefault;

lib/src/test/java/org/sonarsource/scanner/lib/internal/IsolatedLauncherFactoryTest.java

@@ -19,13 +19,11 @@
  */
 package org.sonarsource.scanner.lib.internal;
 
-import java.nio.file.Path;
 import java.util.HashSet;
 import java.util.Map;
 import java.util.Properties;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.io.TempDir;
 import org.sonarsource.scanner.lib.internal.batch.IsolatedLauncher;
 import org.sonarsource.scanner.lib.internal.batch.LogOutput;
 import org.sonarsource.scanner.lib.internal.cache.Logger;
@@ -40,7 +38,7 @@ class IsolatedLauncherFactoryTest {
   LegacyScannerEngineDownloader legacyScannerEngineDownloader;
 
   @BeforeEach
-  public void setUp(@TempDir Path sonarUserHome) {
+  public void setUp() {
     tempCleaning = mock(TempCleaning.class);
     factory = new IsolatedLauncherFactory(FakeIsolatedLauncher.class.getName(), tempCleaning, mock(Logger.class));
     props = new Properties();

lib/src/test/java/org/sonarsource/scanner/lib/internal/LegacyScannerEngineDownloaderFactoryTest.java

@@ -19,9 +19,7 @@
  */
 package org.sonarsource.scanner.lib.internal;
 
-import java.nio.file.Path;
 import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.io.TempDir;
 import org.sonarsource.scanner.lib.internal.cache.FileCache;
 import org.sonarsource.scanner.lib.internal.cache.Logger;
 import org.sonarsource.scanner.lib.internal.http.ServerConnection;
@@ -31,10 +29,10 @@
 
 class LegacyScannerEngineDownloaderFactoryTest {
   @Test
-  void should_create(@TempDir Path sonarUserHome) {
+  void should_create() {
     ServerConnection conn = mock(ServerConnection.class);
     Logger logger = mock(Logger.class);
     FileCache cache = mock(FileCache.class);
-    assertThat(new JarDownloaderFactory(conn, logger, cache).create()).isNotNull();
+    assertThat(new LegacyScannerEngineDownloaderFactory(conn, logger, cache).create()).isNotNull();
   }
 }